bug: no applicant email #5199
Merged
bug: no applicant email #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
danlipert and
octavioamu
as code owners
octavioamu
reviewed
Sep 16, 2019
| try: | ||
| send_mail( | ||
| from_email, | ||
| to_email, |
There was a problem hiding this comment.
this doesn't need to be a param on the fnc ?
There was a problem hiding this comment.
There was a problem hiding this comment.
you are right, got confused with the "render" .
Codecov Report
@@ Coverage Diff @@
## master #5199 +/- ##
==========================================
- Coverage 30.78% 30.75% -0.04%
==========================================
Files 221 221
Lines 17829 17827 -2
Branches 2464 2463 -1
==========================================
- Hits 5489 5483 -6
- Misses 12114 12118 +4
Partials 226 226
Continue to review full report at Codecov.
|
thelostone-mc
force-pushed
the
email-bug
branch
from
6293275 to
2bbf982
Compare
octavioamu
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like there are a couple of undefined variables which needed to be fixed!
render_no_applicant_remindertakes only one argument as shown hereliveis not defined anywhere so it would not work