Clr backend #5192
Clr backend #5192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5192 +/- ##
===========================================
- Coverage 30.82% 17.74% -13.08%
===========================================
Files 221 210 -11
Lines 17785 18405 +620
Branches 2455 2677 +222
===========================================
- Hits 5482 3266 -2216
- Misses 12077 15104 +3027
+ Partials 226 35 -191
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5192 +/- ##
==========================================
- Coverage 30.78% 30.54% -0.24%
==========================================
Files 221 223 +2
Lines 17943 18095 +152
Branches 2491 2527 +36
==========================================
+ Hits 5524 5528 +4
- Misses 12189 12334 +145
- Partials 230 233 +3
Continue to review full report at Codecov.
|
thelostone-mc
force-pushed
the
clr-backend
branch
from
0fe7b14 to
3e068f2
Compare
thelostone-mc
force-pushed
the
clr-backend
branch
from
3e068f2 to
dfc1be0
Compare
danlipert
requested review from
octavioamu and
thelostone-mc
as code owners
| @@ -146,22 +153,101 @@ | |||
| bottom: -1.2rem; | |||
| } | |||
|
|
|||
| .nav{ | |||
| .nav { | |||
There was a problem hiding this comment.
user text-center calls instead of overwriting the framework
| text-align: center; | ||
| } | ||
| .nav-link{ | ||
|
|
||
| .nav-link { |
There was a problem hiding this comment.
extend core class don't overwrite
| border-right: 1px solid black; | ||
| border-top: 1px solid black; | ||
| border-left: 1px solid black; | ||
| margin-right: 10px; | ||
| } | ||
| .nav-link:visited{ | ||
|
|
||
| .nav-link:visited { |
There was a problem hiding this comment.
extend core class don't overwrite
| color: black; | ||
| } | ||
| .nav-item.active{ | ||
|
|
||
| .nav-item.active { |
There was a problem hiding this comment.
extend core class don't overwrite
| @@ -23,7 +30,7 @@ $(document).ready(function() { | |||
|
|
|||
| updateSummary(); | |||
|
|
|||
| $('.nav-item').click(function(e) { | |||
| $('#grants_form .nav-item').click(function(e) { | |||
There was a problem hiding this comment.
this kind of rules will be a problem when we start creating a bundle js since we are not going to control this being loaded in other areas, use custom classes or data attr
There was a problem hiding this comment.
agreed this would need to be fixed in a follow up PR to use what the tabs we already have
It's creating random weird bugs in css cause of that
cc @owocki
| @@ -40,7 +40,7 @@ <h2 class="grant-item__title font-subheader"><a href="{% url 'grants:details' gr | |||
| {% if clr_active %} | |||
| <div class="clr position-absolute text-center"> | |||
| <h2 class="font-caption font-weight-bold my-0 p-1"> | |||
| CLR MATCH <span id="clr-grant-match">{{ grant.clr_prediction_curve.0}}</span> DAI | |||
| CLR MATCH <span id="clr-grant-match">{{ grant.clr_prediction_curve.0.1|floatformat:2 }}</span> DAI | |||
Description
Refers/Fixes
#3663
Testing
Mocks : Fund Page + Grant Card