remove _alert already used and fix metamask #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
requested review from
danlipert and
thelostone-mc
as code owners
| $('#metamask_connect').css('color', 'white'); | ||
| $('#metamask_connect').css('border', '2px solid white'); | ||
| $('#metamask_connect').css('border-radius', '10px'); | ||
| console.log(page_url) |
thelostone-mc
approved these changes
Sep 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #5184 +/- ##
=======================================
Coverage 30.82% 30.82%
=======================================
Files 221 221
Lines 17783 17783
Branches 2454 2454
=======================================
Hits 5482 5482
Misses 12072 12072
Partials 229 229Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix _alert duplication,
remove web3alert.js (actually wasn't working)
Refers/Fixes
Testing