Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/disconnect-github-5166 #5178

Merged
merged 2 commits into from
Sep 19, 2019
Merged

bug/disconnect-github-5166 #5178

merged 2 commits into from
Sep 19, 2019

Conversation

androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Sep 12, 2019

Description

Account Settings
- disconnect Github action updated
- now logs out and directs the user to the Github OAuth app settings page for the user to revoke the connection

Refers/Fixes

closes #5166

Testing

The user has to manually revoke the permissions granted to the Gitcoin oAuth application from inside the Github settings page, testing does not apply.

	- disconnect Github action updated
	  - now logs out and directs the user to the Github OAuth app settings page for the user to revoke the connection
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #5178 into master will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
+ Coverage   30.71%   30.71%   +<.01%     
==========================================
  Files         221      221              
  Lines       17868    17870       +2     
  Branches     2469     2469              
==========================================
+ Hits         5488     5489       +1     
+ Misses      12154    12152       -2     
- Partials      226      229       +3
Impacted Files Coverage Δ
app/marketing/views.py 11.88% <25%> (+0.19%) ⬆️
app/dashboard/views.py 14.19% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee1537...d565d59. Read the comment docs.

@octavioamu octavioamu merged commit 2cadb0c into master Sep 19, 2019
@thelostone-mc thelostone-mc deleted the bug/disconnect-gh-5166 branch June 27, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github account reconnects after disconnection if user presses back button
4 participants