Fix ENS onepager layout #5177
Merged
Fix ENS onepager layout #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing duppicate stylesheets (already loaded at shared/head.html) * Removing favicon include (already loaded at shared/head.html) * Fixing ENS page footer
sergejmueller
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5177 +/- ##
=======================================
Coverage 30.86% 30.86%
=======================================
Files 220 220
Lines 17765 17765
Branches 2451 2451
=======================================
Hits 5483 5483
Misses 12056 12056
Partials 226 226Continue to review full report at Codecov.
|
|
@sergejmueller left 2 comments but otherwise, this looks solid 🙌 |
danlipert
approved these changes
Sep 17, 2019
thelostone-mc
approved these changes
Sep 17, 2019
|
maybe needs a re-merge? sorry if this is related to my backing out my branch |
|
Don't worry we did it here #5229 |
|
Looks good, thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ENS subdomain onepager is a little bit broken. I will try to fix the layout.
Before
After
Refers/Fixes
Testing
A designer should make a visual test of the layout changes.