Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix success rate math #5167

Merged
merged 2 commits into from
Sep 11, 2019
Merged

fix success rate math #5167

merged 2 commits into from
Sep 11, 2019

Conversation

danlipert
Copy link
Contributor

Fixes the success rate calculation

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #5167 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5167      +/-   ##
==========================================
- Coverage    30.9%   30.88%   -0.02%     
==========================================
  Files         220      220              
  Lines       17702    17702              
  Branches     2439     2439              
==========================================
- Hits         5470     5468       -2     
- Misses      12006    12007       +1     
- Partials      226      227       +1
Impacted Files Coverage Δ
app/dashboard/models.py 56.44% <0%> (ø) ⬆️
app/dashboard/utils.py 40.73% <0%> (-0.46%) ⬇️
app/dashboard/views.py 14.41% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae798f1...7a1593d. Read the comment docs.

@danlipert danlipert merged commit 8218fa1 into master Sep 11, 2019
@thelostone-mc thelostone-mc deleted the fix-success-rate branch June 27, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants