Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/setup clr round 3 #5161

Merged
merged 9 commits into from
Sep 11, 2019
Merged

Feature/setup clr round 3 #5161

merged 9 commits into from
Sep 11, 2019

Conversation

androolloyd
Copy link
Contributor

Description

New Management Command

  • setup_clr_round_3
  • creates a new group (Grants-CLR-Round-3)
  • enables the add_clrmatch permission
  • adds any users who have an account that was created before Feb 15, 2019
Refers/Fixes

#4369

Testing

There is no testing associated with this ticket.

	- add valid users to the newly created Grants-CLR-Round-3
	- valid user filter set for the 1st of March 2019
@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #5161 into master will decrease coverage by 0.7%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5161      +/-   ##
=========================================
- Coverage    30.9%   30.2%   -0.71%     
=========================================
  Files         219     220       +1     
  Lines       17683   18693    +1010     
  Branches     2437    2700     +263     
=========================================
+ Hits         5465    5646     +181     
- Misses      11994   12791     +797     
- Partials      224     256      +32
Impacted Files Coverage Δ
...ashboard/management/commands/setup_grants_clr_3.py 0% <0%> (ø)
app/kudos/views.py 19.79% <0%> (-2.95%) ⬇️
app/grants/views.py 13.93% <0%> (-0.84%) ⬇️
app/dashboard/models.py 56.7% <0%> (+0.25%) ⬆️
app/dashboard/router.py 36.44% <0%> (+0.5%) ⬆️
app/dashboard/views.py 14.81% <0%> (+0.55%) ⬆️
app/retail/emails.py 24.27% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0019d2...0f19148. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1a78694). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5161   +/-   ##
=========================================
  Coverage          ?   30.93%           
=========================================
  Files             ?      220           
  Lines             ?    17702           
  Branches          ?     2439           
=========================================
  Hits              ?     5476           
  Misses            ?    11999           
  Partials          ?      227
Impacted Files Coverage Δ
...ashboard/management/commands/setup_grants_clr_3.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a78694...83434a9. Read the comment docs.

@danlipert
Copy link
Contributor

Sweet! Can you add a cronjob for this that runs every day? That way we don't have to re-run the command as new users come aboard

@danlipert danlipert merged commit e1772c1 into master Sep 11, 2019
@thelostone-mc thelostone-mc deleted the feature/setup-clr-round-3 branch June 27, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants