new profile data methods #5159

owocki · 2019-09-09T20:37:55Z

Description

this commit adds methods for calculating all the info needed on profiles to give them activity data

Refers/Fixes

#4908

Testing

locally

https://gitcoincore.slack.com/archives/CMGLVLSJX/p1568078390010700g

…les to give them activity data

codecov · 2019-09-09T20:44:50Z

Codecov Report

Merging #5159 into kevin/profile-v2 will increase coverage by 0.24%.
The diff coverage is 49.34%.

@@                 Coverage Diff                  @@
##           kevin/profile-v2    #5159      +/-   ##
====================================================
+ Coverage              30.9%   31.15%   +0.24%     
====================================================
  Files                   217      219       +2     
  Lines                 17622    17774     +152     
  Branches               2430     2460      +30     
====================================================
+ Hits                   5446     5537      +91     
- Misses                11953    11998      +45     
- Partials                223      239      +16

Impacted Files	Coverage Δ
app/app/urls.py	`89.36% <ø> (ø)`	⬆️
...ashboard/management/commands/create_rep_records.py	`0% <0%> (ø)`
...board/management/commands/cleanup_dupe_profiles.py	`0% <0%> (ø)`	⬆️
app/dashboard/admin.py	`63.94% <100%> (+0.88%)`	⬆️
app/dashboard/points.py	`100% <100%> (ø)`
app/dashboard/views.py	`13.7% <6.25%> (-0.08%)`	⬇️
app/dashboard/models.py	`57% <61.26%> (+1.14%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b2f71...480be13. Read the comment docs.

iamonuwa · 2019-09-09T22:03:23Z

Super dope

frankchen07 · 2019-09-10T06:11:48Z

app/dashboard/models.py

@@ -2105,6 +2129,12 @@ class Profile(SuperModel):
        help_text=_('override profile avatar'),
    )
    dominant_persona = models.CharField(max_length=25, choices=PERSONAS, blank=True)
+    longest_streak = models.IntegerField(default=0)
+    activity_level = models.CharField(max_length=10, blank=True, help_text=_('the users activity level (high, low, new)'))


did you forget medium? (I guess it's only the help text)

in the help text only yes

frankchen07 · 2019-09-10T06:13:35Z

app/dashboard/models.py

+            return "High"
+        if visits_last_month > med_threshold:
+            return "Medium"
+        if visits_last_month > med_threshold:


should this be visits_last_month < med_threshold?

no; d1574cc

frankchen07 · 2019-09-10T06:14:58Z

app/dashboard/models.py

+
+        if visits_last_month > high_threshold:
+            return "High"
+        if visits_last_month > med_threshold:


med_threshold is the same as high_threshold, does that make sense?

also - should there be an upper bound as well? (visits_last_month > med_threshold and <= high_threshold?)

yeah.... it is.

alos i just made this up... you guys tell me what the thresholds should be pls. in particular, @frankchen07 curious your opionion

I think it's fine where it is - 15 stands to be a visit every other day, medium is 2 visit per week, and lower than that is low.

frankchen07 · 2019-09-10T06:23:55Z

app/dashboard/models.py

+            if bounty.is_funder(self.handle):
+                for handle in fulfiller_handles:
+                    relationships.append(handle)
+            if self.handle in fulfiller_handles:


nice this handles both funder -> fulfiller and and vice versa

frankchen07 · 2019-09-10T06:26:04Z

app/dashboard/models.py

+        eligible_bounties = bounties.filter(idx_status__in=['done', 'expired', 'cancelled'])
+
+        if eligible_bounties.count() == 0:
+            return -1


its a way of saying "this user hasnt done any bounties; pls dont display on frontend". as opposed to 0 which is for when the user has made $0/hr for many bounties

frankchen07 · 2019-09-10T06:38:00Z

app/dashboard/models.py

+            iterdate += timezone.timedelta(days=1)
+
+            is_weekday = iterdate.weekday() < 5
+            if not is_weekday:


shouldn't weekends be counted in the streak as well?

also is the if not is_weekday grabbing weekends here? if its 5 or greater is_weekday is false and the if not will render true, and it'll continue, no?

the if not weekday thing is an if statement that calls a continue which effectivbely skips weekend days

i dont think weekends should count in the streak mechanic.. we dont want to build a culture that encourages burnout

owocki

would <3 a review from @gitcoinco/engineers

owocki · 2019-09-10T16:28:24Z

app/dashboard/models.py

+            if bounty.is_funder(self.handle):
+                for handle in fulfiller_handles:
+                    relationships.append(handle)
+            if self.handle in fulfiller_handles:


owocki · 2019-09-10T16:29:01Z

app/dashboard/models.py

+        eligible_bounties = bounties.filter(idx_status__in=['done', 'expired', 'cancelled'])
+
+        if eligible_bounties.count() == 0:
+            return -1


its a way of saying "this user hasnt done any bounties; pls dont display on frontend". as opposed to 0 which is for when the user has made $0/hr for many bounties

owocki · 2019-09-10T16:29:17Z

app/dashboard/models.py

@@ -2105,6 +2129,12 @@ class Profile(SuperModel):
        help_text=_('override profile avatar'),
    )
    dominant_persona = models.CharField(max_length=25, choices=PERSONAS, blank=True)
+    longest_streak = models.IntegerField(default=0)
+    activity_level = models.CharField(max_length=10, blank=True, help_text=_('the users activity level (high, low, new)'))


in the help text only yes

owocki · 2019-09-10T16:29:51Z

app/dashboard/models.py

+
+        if visits_last_month > high_threshold:
+            return "High"
+        if visits_last_month > med_threshold:


yeah.... it is.

alos i just made this up... you guys tell me what the thresholds should be pls. in particular, @frankchen07 curious your opionion

this commit adds methods for calculating all the info needed on profi…

a86ea4b

…les to give them activity data

owocki requested review from danlipert, octavioamu and thelostone-mc as code owners September 9, 2019 20:37

make fix

75b1315

owocki added 2 commits September 9, 2019 15:18

profile rep

0c60cf7

admin color

8a46306

smallfix

2219625

frankchen07 reviewed Sep 10, 2019

View reviewed changes

owocki commented Sep 10, 2019

View reviewed changes

owocki added 3 commits September 10, 2019 15:19

med

d1574cc

fixes issue with 3/5

8ef46fc

make fix

480be13

owocki merged commit 480be13 into kevin/profile-v2 Sep 11, 2019

thelostone-mc deleted the kevin/profile-v2-data branch June 27, 2020 00:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new profile data methods #5159

new profile data methods #5159

owocki commented Sep 9, 2019 •

edited

Loading

codecov bot commented Sep 9, 2019 •

edited

Loading

iamonuwa commented Sep 9, 2019

frankchen07 Sep 10, 2019

owocki Sep 10, 2019

frankchen07 Sep 10, 2019

owocki Sep 10, 2019

frankchen07 Sep 10, 2019 •

edited

Loading

owocki Sep 10, 2019

frankchen07 Sep 11, 2019 •

edited

Loading

frankchen07 Sep 10, 2019

owocki Sep 10, 2019

frankchen07 Sep 10, 2019

owocki Sep 10, 2019

frankchen07 Sep 10, 2019

owocki Sep 10, 2019 •

edited

Loading

owocki left a comment

owocki Sep 10, 2019

owocki Sep 10, 2019

owocki Sep 10, 2019

owocki Sep 10, 2019

new profile data methods #5159

new profile data methods #5159

Conversation

owocki commented Sep 9, 2019 • edited Loading

Description

Refers/Fixes

Testing

codecov bot commented Sep 9, 2019 • edited Loading

Codecov Report

iamonuwa commented Sep 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frankchen07 Sep 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frankchen07 Sep 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki Sep 10, 2019 • edited Loading

Choose a reason for hiding this comment

owocki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Sep 9, 2019 •

edited

Loading

codecov bot commented Sep 9, 2019 •

edited

Loading

frankchen07 Sep 10, 2019 •

edited

Loading

frankchen07 Sep 11, 2019 •

edited

Loading

owocki Sep 10, 2019 •

edited

Loading