Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude null or empty users #5136

Merged
merged 3 commits into from
Sep 10, 2019
Merged

exclude null or empty users #5136

merged 3 commits into from
Sep 10, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Sep 5, 2019

Description

Remove empty users from query making the search filter to fail on new bounty invite

Refers/Fixes

#5090 (comment)

Testing

locally tested

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #5136 into master will decrease coverage by 0.4%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5136      +/-   ##
=========================================
- Coverage   30.91%   30.5%   -0.41%     
=========================================
  Files         219     219              
  Lines       17687   18228     +541     
  Branches     2438    2614     +176     
=========================================
+ Hits         5468    5561      +93     
- Misses      11994   12428     +434     
- Partials      225     239      +14
Impacted Files Coverage Δ
app/dashboard/views.py 15.15% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952f437...0d70159. Read the comment docs.

@danlipert danlipert merged commit a8a82ab into master Sep 10, 2019
@thelostone-mc thelostone-mc deleted the fix/nullusers branch June 27, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants