Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactoring popover on bounty details #5135

Merged
merged 15 commits into from
Sep 11, 2019
Merged

feat: refactoring popover on bounty details #5135

merged 15 commits into from
Sep 11, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Sep 5, 2019 •
edited by octavioamu
Loading

Description
  • refactored code + updated UI to match mock
  • wired up BE query
Refers/Fixes

#5036
fix https://gitcoincore.slack.com/archives/CAXQ7PT60/p1567628057033200

Testing

Screenshot 2019-09-06 at 8 31 50 PM

Screenshot 2019-09-06 at 5 38 51 PM

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #5135 into master will decrease coverage by 0.01%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5135      +/-   ##
==========================================
- Coverage   30.88%   30.87%   -0.02%     
==========================================
  Files         220      220              
  Lines       17702    17713      +11     
  Branches     2439     2443       +4     
==========================================
+ Hits         5468     5469       +1     
- Misses      12009    12017       +8     
- Partials      225      227       +2
Impacted Files Coverage Δ
app/dashboard/models.py 56.41% <33.33%> (-0.04%) ⬇️
app/dashboard/views.py 14.34% <7.14%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8218fa1...5415d9a. Read the comment docs.

@thelostone-mc
Copy link
Member Author

I got this error twice redis.exceptions.ResponseError: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE. after I threw in the bounty query!

@danlipert left a bunch of TODOS I need help with

@octavioamu
Copy link
Contributor

@thelostone-mc I think I found a way to solve the queries.
One important think I changed the query logic to be based on the current bounty skills, not the profile skills.

@thelostone-mc thelostone-mc force-pushed the popover branch 2 times, most recently from 97588b8 to b895cf2 Compare September 6, 2019 12:05
@thelostone-mc thelostone-mc marked this pull request as ready for review September 6, 2019 14:21
danlipert
danlipert reviewed Sep 11, 2019
View reviewed changes
app/dashboard/views.py Outdated
keywords = request.GET.get('keywords', '')

bounties = Bounty.objects.current().prefetch_related('fulfillments', 'interested', 'interested__profile', 'feedbacks') \
.filter(interested__profile=profile, network=network,) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to show you some efficient Python style sometime :) you don't need to resort to the \ https://www.python.org/dev/peps/pep-0008/#maximum-line-length

danlipert
danlipert previously approved these changes Sep 11, 2019
View reviewed changes
@octavioamu octavioamu merged commit 787ebbd into master Sep 11, 2019
@thelostone-mc thelostone-mc deleted the popover branch September 11, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavioamu octavioamu octavioamu approved these changes

@danlipert danlipert danlipert left review comments

Assignees

@danlipert danlipert

@octavioamu octavioamu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelostone-mc @octavioamu @danlipert