add missing events and fixes for gtm #5127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5127 +/- ##
==========================================
- Coverage 30.9% 30.83% -0.08%
==========================================
Files 219 219
Lines 17618 17980 +362
Branches 2427 2520 +93
==========================================
+ Hits 5445 5544 +99
- Misses 11950 12189 +239
- Partials 223 247 +24
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #5127 +/- ##
==========================================
- Coverage 30.9% 30.83% -0.08%
==========================================
Files 219 219
Lines 17618 17980 +362
Branches 2427 2520 +93
==========================================
+ Hits 5445 5544 +99
- Misses 11950 12189 +239
- Partials 223 247 +24
Continue to review full report at Codecov.
|
danlipert
approved these changes
Sep 4, 2019
| @@ -73,6 +73,7 @@ | |||
| <div class="form_container"> | |||
| <ul class="nav nav-tabs"> | |||
| {% for nav in navs %} | |||
| <!-- {{nav.href}} {{active}} --> | |||
There was a problem hiding this comment.
What does this change do?
There was a problem hiding this comment.
ohh I miss that one, was a test
thelostone-mc
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add and fix GTM events
together with gtm changes for tracking
Add data-gtm as auto tracking attr
Refers/Fixes
Testing
locally, intensive