Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turtle neck design #5122

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Add turtle neck design #5122

merged 3 commits into from
Sep 6, 2019

Conversation

iamonuwa
Copy link
Contributor

@iamonuwa iamonuwa commented Sep 3, 2019

Description

As requested by a twitter user https://twitter.com/abbey_titcomb/status/1167446204332040198

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #5122 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5122      +/-   ##
==========================================
- Coverage   30.92%   30.86%   -0.06%     
==========================================
  Files         219      219              
  Lines       17597    17656      +59     
  Branches     2426     2435       +9     
==========================================
+ Hits         5442     5450       +8     
- Misses      11932    11983      +51     
  Partials      223      223
Impacted Files Coverage Δ
app/avatar/utils.py 13.19% <ø> (ø) ⬆️
app/dashboard/models.py 56.42% <0%> (-0.22%) ⬇️
app/marketing/mails.py 14.26% <0%> (-0.11%) ⬇️
app/dashboard/views.py 13.96% <0%> (-0.1%) ⬇️
app/retail/utils.py 10.12% <0%> (-0.06%) ⬇️
app/retail/emails.py 23.57% <0%> (-0.03%) ⬇️
app/app/urls.py 89.36% <0%> (ø) ⬆️
app/marketing/views.py 11.9% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54efd11...300d2f0. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Sep 3, 2019

screenshot??

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Sep 3, 2019

I can't get to load into the app after running make collect-static

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Sep 3, 2019

IMG-20190902-WA0007
This is how it looks

@owocki
Copy link
Contributor

owocki commented Sep 5, 2019

LGTM... @gitcoinco/engineers ?

@owocki
Copy link
Contributor

owocki commented Sep 5, 2019

actually u need to add it to avatar/utils @iamonuwa .. did you test this? screenshot of it working?

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Sep 5, 2019

Let me do this immediately

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Sep 5, 2019

The design is now loading and works
image

@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 6, 2019

Thanks @iamonuwa for the screenshots ^_^
@owocki @gitcoinco/engineers give it a 👍

@thelostone-mc thelostone-mc merged commit 05614dd into gitcoinco:master Sep 6, 2019
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.15000 ETH (25.74 USD @ $171.6/ETH) has been granted to @iamonuwa for this issue from @owocki. ⚡️

Nice work @iamonuwa! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants