Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitCoin Bot document link #5117

Merged

Conversation

think-in-universe
Copy link
Contributor

Description

Fix GitCoin Bot document link

Refers/Fixes

#5116

Testing

preview markdown

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #5117 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5117      +/-   ##
==========================================
- Coverage   31.03%   30.85%   -0.18%     
==========================================
  Files         218      219       +1     
  Lines       17537    17661     +124     
  Branches     2414     2435      +21     
==========================================
+ Hits         5442     5450       +8     
- Misses      11870    11988     +118     
+ Partials      225      223       -2
Impacted Files Coverage Δ
app/dashboard/models.py 56.42% <0%> (-0.22%) ⬇️
app/marketing/views.py 11.74% <0%> (-0.12%) ⬇️
app/marketing/mails.py 14.26% <0%> (-0.11%) ⬇️
app/dashboard/views.py 13.96% <0%> (-0.1%) ⬇️
app/retail/utils.py 10.12% <0%> (-0.06%) ⬇️
app/retail/emails.py 23.57% <0%> (-0.03%) ⬇️
app/app/urls.py 89.36% <0%> (ø) ⬆️
app/retail/views.py 29.26% <0%> (ø) ⬆️
...arketing/management/commands/export_graph_edges.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51072be...d89ef1f. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still would lean towards having the relative path as opposed to the absolute !
If we end up switching the default branch / stuff like that = extra effort
Please the rest of the readme use relative path

@think-in-universe
Copy link
Contributor Author

Considering maintenance cost, I would agree that we keep the relative path.

However, the current link (https://docs.gitcoin.co/app/gitcoinbot/README.md) to the gitcoinbot page is broken, and I would prefer we have some way to make the link available in https://docs.gitcoin.co/#integrating-gitcoin

What's the tool that is used to generate the https://docs.gitcoin.co ? Maybe we can create a mirror/copy to the gitcoinbot page under /docs folder in this repo.

@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 4, 2019

Ah we use pydocmd 🙌 !
mind checking that out and updating it there ?

https://github.com/gitcoinco/web/blob/master/pydocmd.yml

@think-in-universe
Copy link
Contributor Author

I added a page https://docs.gitcoin.co/md_gitcoinbot for GitcoinBot to fix the link

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWEET thanks @think-in-universe

@thelostone-mc thelostone-mc merged commit 6c7d15e into gitcoinco:master Sep 6, 2019
@gitcoinbot
Copy link
Member

Eye For Detail ⚡️ A *Eye For Detail* Kudos has been sent to @think-in-universe for this issue from @thelostone-mc. ⚡️

The sender had the following public comments:

Thanks for helping with the grunt work !
Appreciate it and welcome to the community ^_^

Nice work @think-in-universe!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.50000 ETH (72.27 USD @ $144.54/ETH) has been granted to @think-in-universe for this issue from @owocki. ⚡️

Nice work @think-in-universe! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants