-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitCoin Bot document link #5117
Fix GitCoin Bot document link #5117
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5117 +/- ##
==========================================
- Coverage 31.03% 30.85% -0.18%
==========================================
Files 218 219 +1
Lines 17537 17661 +124
Branches 2414 2435 +21
==========================================
+ Hits 5442 5450 +8
- Misses 11870 11988 +118
+ Partials 225 223 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still would lean towards having the relative path as opposed to the absolute !
If we end up switching the default branch / stuff like that = extra effort
Please the rest of the readme use relative path
Considering maintenance cost, I would agree that we keep the relative path. However, the current link (https://docs.gitcoin.co/app/gitcoinbot/README.md) to the gitcoinbot page is broken, and I would prefer we have some way to make the link available in https://docs.gitcoin.co/#integrating-gitcoin What's the tool that is used to generate the https://docs.gitcoin.co ? Maybe we can create a mirror/copy to the gitcoinbot page under /docs folder in this repo. |
Ah we use pydocmd 🙌 ! https://github.com/gitcoinco/web/blob/master/pydocmd.yml |
I added a page https://docs.gitcoin.co/md_gitcoinbot for GitcoinBot to fix the link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SWEET thanks @think-in-universe
|
⚡️ A tip worth 0.50000 ETH (72.27 USD @ $144.54/ETH) has been granted to @think-in-universe for this issue from @owocki. ⚡️ Nice work @think-in-universe! Your tip has automatically been deposited in the ETH address we have on file.
|
Description
Fix GitCoin Bot document link
Refers/Fixes
#5116
Testing
preview markdown