Preload fonts from the static domain #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all fonts are loaded from the CDN subdomain https://s.gitcoin.co, but the preloader gets the fonts from the main domain https://gitcoin.co. In order to benefit from the browser preloader, the domain should be adapted.
sergejmueller
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5114 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 218 218
Lines 17537 17537
Branches 2414 2414
=======================================
Hits 5442 5442
Misses 11872 11872
Partials 223 223Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #5114 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 218 218
Lines 17537 17537
Branches 2414 2414
=======================================
Hits 5442 5442
Misses 11872 11872
Partials 223 223Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all fonts are loaded from the CDN subdomain https://s.gitcoin.co, but the preloader gets the fonts from the main domain https://gitcoin.co. In order to benefit from the browser preloader, the domain should be adapted.
Testing
Sorry, no tests.