catch infura/metamask errors before they alert sentry #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
previously approved these changes
Sep 4, 2019
thelostone-mc
previously approved these changes
Sep 4, 2019
danlipert
dismissed stale reviews from thelostone-mc and octavioamu
via
848cfaf
Codecov Report
@@ Coverage Diff @@
## master #5113 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 218 218
Lines 17537 17537
Branches 2414 2414
=======================================
Hits 5442 5442
Misses 11872 11872
Partials 223 223Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5113 +/- ##
=======================================
Coverage 30.87% 30.87%
=======================================
Files 219 219
Lines 17649 17649
Branches 2435 2435
=======================================
Hits 5449 5449
+ Misses 11977 11975 -2
- Partials 223 225 +2
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use a variety of techniques in our shared.js to determine whether the user has web3 access. One of the ways we do it is to attempt to access the coinbase of the connected ETH node - if the coinbase comes back as something other than undefined, then we assume we have a working blockchain connection. However, when calling this synchronous method in browsers that do not have metamask unlocked, we get an error trying to access the coinbase, and use this to show the user the "unlock metamask" alert. Each time this happens however, an alert is sent to sentry.
Refers/Fixes
This PR catches the error.
Testing
Untested