Feature/celery 4976-In Review

[androolloyd]

Description

Celery Task Scheulder and Worker Setup

• dashboard/tasks.py
  • bounty_email task
    • locks on the invite_url
      requirements/base.txt
  • django_celery_beat depdency added
  • celery dependency

RedisService added
Settings.py

• celery specific env variables added

docker-compose.yml

• worker and scheduler added

Refers/Fixes

#4976

Testing

Testing Still needed

[androolloyd]

Some questions remain around sending emails, I noticed there are some administrator features around sending bounty emails, all aspects of sending bounty emails will need to be tested end 2 end.

[danlipert]

@androolloyd whats left to do on this one so we can get it merged, hopefully by Wednesday?

[danlipert]

@androolloyd any updates on this? Also, I'm wondering why we need the scheduler here since we aren't actually doing scheduling? Is it just so we can space out the emails over time?

[androolloyd]

The scheduler could be turned off for now i suppose, it executes what gets defined in the database for periodic tasks.

IIRC its not required for the email job to function.

[danlipert]

The scheduler could be turned off for now i suppose, it executes what gets defined in the database for periodic tasks.

IIRC its not required for the email job to function.

cool, in that case lets remove it for now so we don't prematurely grow the codebase

[codecov]

Codecov Report

Merging #5110 into master will increase coverage by 1.74%.
The diff coverage is 60.75%.

@@            Coverage Diff             @@
##           master    #5110      +/-   ##
==========================================
+ Coverage   29.12%   30.86%   +1.74%     
==========================================
  Files         242      247       +5     
  Lines       20912    23441    +2529     
  Branches     3023     3704     +681     
==========================================
+ Hits         6091     7236    +1145     
- Misses      14576    15880    +1304     
- Partials      245      325      +80

Impacted Files	Coverage Δ
app/marketing/mails.py	13.74% <0%> (-0.04%)	⬇️
app/dashboard/tasks.py	50% <50%> (ø)
app/app/redis_service.py	90% <90%> (ø)
app/app/settings.py	80.56% <92.85%> (+0.91%)	⬆️
app/taskapp/celery.py	93.33% <93.33%> (ø)
app/app/urls.py	85.93% <0%> (-4.07%)	⬇️
app/grants/views.py	15.53% <0%> (-0.8%)	⬇️
...rketing/management/commands/no_applicants_email.py	0% <0%> (ø)	⬆️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8eed88...4426cf3. Read the comment docs.

[androolloyd]

This is ready for deployment

[androolloyd]

The workers are running on the celery server, once the app has been updated it should start queueing jobs to redis. The worker box should get switched back to master and get updated to the latest version as apart of the deploy.

[octavioamu]

@androolloyd I noticed the file app/assets/v2/js/lib/secrets.min.js was changed to unminified file, probably another version. is that ok? Also shouldn't be good to put a minified version?