save es keywords to profile and fix onboarding #5105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5105 +/- ##
==========================================
+ Coverage 31.03% 31.05% +0.01%
==========================================
Files 218 219 +1
Lines 17536 18926 +1390
Branches 2413 2840 +427
==========================================
+ Hits 5442 5877 +435
- Misses 11871 12773 +902
- Partials 223 276 +53
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5105 +/- ##
==========================================
- Coverage 31.03% 31.02% -0.01%
==========================================
Files 218 218
Lines 17536 17538 +2
Branches 2413 2413
==========================================
Hits 5442 5442
Misses 11871 11871
- Partials 223 225 +2
Continue to review full report at Codecov.
|
| if ($('.navbar #navbarDropdown').html()) { | ||
| var url = '/api/v0.1/profile/' + $('.navbar #navbarDropdown').html().trim() + '/keywords'; | ||
| if (document.contxt.github_handle) { | ||
| var url = `/api/v0.1/profile/${document.contxt.github_handle}/keywords`; |
There was a problem hiding this comment.
changed this because menu changed and now $('.navbar #navbarDropdown') wasn't the user gh, was "Products"
| @@ -105,7 +105,7 @@ onboard.watchMetamask = function() { | |||
| } | |||
| }; | |||
|
|
|||
| onboard.getFilters = function(savedKeywords) { | |||
| onboard.getFilters = function(savedKeywords, currentKeywords) { | |||
There was a problem hiding this comment.
added parameters because was saving empty when going out of that page
| }); | ||
| } | ||
|
|
||
| $('.suggested-tag input[type=checkbox]').change(function(e) { | ||
| onboard.getFilters(); | ||
| onboard.getFilters(true); |
There was a problem hiding this comment.
this will save the changes
|
|
||
| $.get(url, function(response) { | ||
| onboard.getFilters(response.keywords); | ||
| onboard.getFilters(false, response.keywords); |
There was a problem hiding this comment.
this will just populate the keywords if you already have any
There was a problem hiding this comment.
LGTM Just added some fixes and comments about it.
Fixed eslint
Tested on 3 diff areas
onboard, settings/matching, user directory
Also using http://localhost:8000/api/v0.1/profile/octavioamu/keywords for each change and everything looks consistent, and when you come back to onboard the skills you picked are pre selected.
profile.keywords had the same values as marketing_emailsubscriber in DB
|
Thanks for the fixes @octavioamu ! appreciate it |
Description
This PR fixes saving of skills/keywords during onboarding, as well as saving the emailsubscriber keyword settings to your user profile so they display in the user directory
Refers/Fixes
#4424
Testing
https://embed.vidyard.com/share/LAXMnXgpZ7RuFkLrkLJeN9?