add simple success rate calculation #5104
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5104 +/- ##
==========================================
- Coverage 31.03% 31.02% -0.01%
==========================================
Files 218 218
Lines 17536 17543 +7
Branches 2413 2414 +1
==========================================
+ Hits 5442 5443 +1
- Misses 11871 11875 +4
- Partials 223 225 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5104 +/- ##
==========================================
+ Coverage 31.03% 31.21% +0.18%
==========================================
Files 218 218
Lines 17536 18492 +956
Branches 2413 2736 +323
==========================================
+ Hits 5442 5772 +330
- Misses 11871 12466 +595
- Partials 223 254 +31
Continue to review full report at Codecov.
|
| num_completed_bounties = self.bounties.filter( | ||
| idx_status__in=['done'], network=network).count() | ||
| terminal_state_bounties = self.bounties.filter( | ||
| idx_status__in=Bounty.TERMINAL_STATUSES, network=network).count() |
There was a problem hiding this comment.
don't know how to solve the cooperative bounty case, since I can be paid out but the bounty still open.
There was a problem hiding this comment.
Is kind of the same situation on the dashboard, should we fetch fulfillments also?
Description
Adds success rate calculation based on already existing calculation found in quarterly stats function
Refers/Fixes
exposes success rate for #5036
Testing
Tested locally:
