Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group by skill and change subject #5081

Merged
merged 6 commits into from
Aug 29, 2019
Merged

Conversation

octavioamu
Copy link
Contributor

Description

image
image

Refers/Fixes

Fix #5048

Testing

thelostone-mc
thelostone-mc previously approved these changes Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #5081 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5081   +/-   ##
=======================================
  Coverage   31.03%   31.03%           
=======================================
  Files         218      218           
  Lines       17515    17515           
  Branches     2404     2404           
=======================================
  Hits         5436     5436           
+ Misses      11856    11855    -1     
- Partials      223      224    +1
Impacted Files Coverage Δ
app/marketing/mails.py 14.36% <0%> (ø) ⬆️
app/dashboard/views.py 14.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9d73e...2a033de. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #5081 into master will decrease coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5081      +/-   ##
==========================================
- Coverage   31.03%   30.66%   -0.38%     
==========================================
  Files         218      218              
  Lines       17515    18106     +591     
  Branches     2404     2600     +196     
==========================================
+ Hits         5436     5552     +116     
- Misses      11856    12299     +443     
- Partials      223      255      +32
Impacted Files Coverage Δ
app/marketing/mails.py 14.36% <0%> (ø) ⬆️
app/dashboard/views.py 15.74% <0%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9d73e...387f7e2. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed lint issues but I get this when I try inviting user
TypeError: processedData[1] is undefined @octavioamu

Also we should throw a message/something when we have no users to populate when we have no users based on skill or even hide the add by skill button

@octavioamu
Copy link
Contributor Author

Yes need to make some changes also the index group changes sometimes is not the 1 is the 0 or 2

@octavioamu
Copy link
Contributor Author

@thelostone-mc done

thelostone-mc
thelostone-mc previously approved these changes Aug 28, 2019
thelostone-mc
thelostone-mc previously approved these changes Aug 28, 2019
@thelostone-mc thelostone-mc merged commit 9738210 into master Aug 29, 2019
@thelostone-mc thelostone-mc deleted the feature/invite-by-skill branch June 27, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invite Groups of Contributors Based on Skills
2 participants