-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add group by skill and change subject #5081
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5081 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 218 218
Lines 17515 17515
Branches 2404 2404
=======================================
Hits 5436 5436
+ Misses 11856 11855 -1
- Partials 223 224 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5081 +/- ##
==========================================
- Coverage 31.03% 30.66% -0.38%
==========================================
Files 218 218
Lines 17515 18106 +591
Branches 2404 2600 +196
==========================================
+ Hits 5436 5552 +116
- Misses 11856 12299 +443
- Partials 223 255 +32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed lint issues but I get this when I try inviting user
TypeError: processedData[1] is undefined
@octavioamu
Also we should throw a message/something when we have no users to populate when we have no users based on skill or even hide the add by skill button
Yes need to make some changes also the index group changes sometimes is not the 1 is the 0 or 2 |
…to feature/invite-by-skill
@thelostone-mc done |
Description
Refers/Fixes
Fix #5048
Testing