Add tax management #5072

PumpkingWok · 2019-08-26T12:39:09Z

Description

Added settings/tax, the user can set own location in it, it is prepopulated with the last location registered from ip.
Develop management command to create a csv for every funder
Create 1099s only for US based users that reach at least 600$ per year.
Send email to all funders.
Add address field

Refers/Fixes

Fixes: #4806

Testing

I tested it locally using docker to setup the environment, i made the db migration manually.

codecov · 2019-08-26T13:13:20Z

Codecov Report

Merging #5072 into master will decrease coverage by 0.11%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master    #5072      +/-   ##
==========================================
- Coverage   31.03%   30.91%   -0.12%     
==========================================
  Files         218      218              
  Lines       17515    17575      +60     
  Branches     2404     2414      +10     
==========================================
- Hits         5436     5434       -2     
- Misses      11856    11918      +62     
  Partials      223      223

Impacted Files	Coverage Δ
app/app/urls.py	`89.36% <ø> (ø)`	⬆️
app/dashboard/models.py	`56.62% <100%> (+0.02%)`	⬆️
app/marketing/views.py	`10.79% <2.17%> (-1.07%)`	⬇️
app/dashboard/views.py	`14.17% <23.07%> (+0.01%)`	⬆️
app/dashboard/embed.py	`28.16% <0%> (-3.45%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e14c7a...2572c6e. Read the comment docs.

codecov · 2019-08-26T13:13:20Z

Codecov Report

Merging #5072 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5072   +/-   ##
=======================================
  Coverage   26.79%   26.79%           
=======================================
  Files         293      293           
  Lines       27538    27538           
  Branches     4069     4069           
=======================================
  Hits         7380     7380           
  Misses      19890    19890           
  Partials      268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4e302...1f4e302. Read the comment docs.

PumpkingWok · 2019-12-01T19:39:39Z

Hi @thelostone-mc @octavioamu,

I'm concluding this issue, right now i'm testing the env using docker and i have imported bounty from rinkeby but I would like to ask you how i can import to db some users profile info. I did it some months ago but unfortunately i did not remember how. For testing it properly in theory i should retrieve all user profile and bounties, tips, grants data from mainnet.

I'm waiting to terminate the command send_tax_report.py because i have to test tips and grants but i could not retrieve them from bounty data on rinkeby.
Thanks in advance.

owocki · 2019-12-16T22:27:30Z

app/marketing/management/commands/send_tax_report.py

+            csv_record = []
+            us_workers = {}
+            # Bounties
+            for b in p.get_sent_bounties:


are we still planning on using Earnings instead?!?

Hi kevin, if you want i can change it into the code without problems but it requires a little more time to make some tests. I could do it during next week.
One question: In Earning the source_id field correspond to id in BountyFulfillment, for instance in bounty case ? Because i try to compare Earning source_id -> BountyFulfillment bounty_id -> Bounty id and for instance the value_usd does not seem to match between earning and bounty. Could you check it ? thanks

owocki · 2019-12-16T22:27:58Z

scripts/crontab

@@ -67,6 +67,7 @@ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/us
 #0 0 1 */3 * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash send_quarterly_stats --live  >> /var/log/gitcoin/send_quarterly_stats.log  2>&1
 00 10 * * 5 cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash post_leaderboard_to_slack  >> /var/log/gitcoin/post_leaderboard_to_slack.log  2>&1
 0 9 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash no_applicants_email  >> /var/log/gitcoin/no_applicants_email.log 2>&1
+0 10 15 1 *  cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash send_tax_report >> /var/log/gitcoin/send_tax_report.log 2>&1


id prefer to just send this manually instead of via cron

Ok no problem, I'm going to delete it.

owocki · 2019-12-16T22:28:14Z

just did a pass ... code is looking good so far!

owocki · 2019-12-18T20:37:06Z

yes please source id == the object thats being refverenced... in the case of bountie fulfillment its the bounty fulfillment id not the bounty id

…

On Wed, Dec 18, 2019 at 12:15 PM andrea zuccarini ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/marketing/management/commands/send_tax_report.py <#5072 (comment)>: > +class Command(BaseCommand): + + help = 'the tax report for last year' + + def handle(self, *args, **options): + to_emails = [] + zip_paths = [] + profiles = Profile.objects.all() + tax_path = os.path.join(os.getcwd(), TAX_REPORT_PATH) + if not tax_path: + os.makedirs(tax_path) + for p in profiles: + csv_record = [] + us_workers = {} + # Bounties + for b in p.get_sent_bounties: Hi kevin, if you want i can change it into the code without problems but it requires a little more time to make some tests. I could do it during next week. One question: In Earning the source_id field correspond to id in BountyFulfillment, for instance in bounty case ? Because i try to compare Earning source_id -> BountyFulfillment bounty_id -> Bounty id and for instance the value_usd does not seem to match between earning and bounty. Could you check it ? thanks — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5072?email_source=notifications&email_token=AAD5PCJXWS4WSGNSQN6T3QTQZJZEFA5CNFSM4IPPG7H2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPVYJ3I#discussion_r359521728>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCJIWZTIWMSWJCU3DETQZJZEFANCNFSM4IPPG7HQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $2.7mm for Open Source Software - see our results <https://gitcoin.co/results>

PumpkingWok · 2019-12-19T19:31:41Z

Hi @owocki,
Yes i understood it, my question was little different.
In the case of bounty for instance, i followed in Earning the source_id (bounty fulfillment id) to the corresponding bountyfulfillment record, in this record there is bounty_id field, then i looked the record in bounty model for this bounty_id and the value_usd does not seem to match. Maybe i have to update the usd price with some commands.
Can you confirm that from Earning i can retrieve the correct bounty info ?
Thanks in advance.

owocki · 2019-12-19T20:08:54Z

yea the USD value will adjust depending upon price fluctuations. you want to use bounty.value_in_usdt_then and itll stay constant

…

On Thu, Dec 19, 2019 at 12:31 PM andrea zuccarini ***@***.***> wrote: Hi @owocki <https://github.com/owocki>, Yes i understood it, my question was little different. In the case of bounty for instance, i followed in Earning the source_id (bounty fulfillment id) to the corresponding bountyfulfillment record, in this record there is bounty_id field, then i looked the record in bounty model for this bounty_id and the value_usd does not seem to match. Maybe i have to update the usd price with some commands. Can you confirm that from Earning i can retrieve the correct bounty info ? Thanks in advance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5072?email_source=notifications&email_token=AAD5PCJPZW4I5FP63CAJR53QZPDZ5A5CNFSM4IPPG7H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKVVCQ#issuecomment-567630474>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCODVINXKST4EQFCAZ3QZPDZ5ANCNFSM4IPPG7HQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $2.7mm for Open Source Software - see our results <https://gitcoin.co/results>

PumpkingWok · 2019-12-21T17:10:00Z

Hi @owocki ,
I have just committed the send_tax_report command refactor for retrieve all info from Earning. I left rinkeby as network.

Question: if a US worker has set only the location via UI and not the address, right now the command sets the address as Location not found inside 1099 form.
Do you prefer that it leaves the field empty ? or maybe it does not create any 1099 at all if the worker did not set both location and address fields via UI tax setting.
Thanks

PumpkingWok · 2019-12-30T18:17:31Z

Hi @owocki,
If you want you can start to test it and after then i can make edit in the code without problems if there is anything that you would like to change.

You can test directly the command send_tax_report to create for each funder a csv file (bounties, tips and grants info) and a 1099s for each us worker that earned more than 600$ from him/her. Lastly it sends an email to all funders with a zip file attached.
Also via UI you can find a new Tax section in Manage Settings for set both address and location.

From comment above:
Question: if a US worker has set only the location via UI and not the address, right now the command sets the address as Location not found inside 1099 form.
Do you prefer that it leaves the field empty ? or maybe it does not create any 1099 at all if the worker did not set both location and address fields via UI tax setting.
I left rinkeby as network inside send_tax_report code, you should change into mainnet.
Thanks.

owocki · 2019-12-31T16:29:32Z

Do you prefer that it leaves the field empty ? or maybe it does not create any 1099 at all if the worker did not set both location and address fields via UI tax setting.

yeah sure leave it empty

testing now

owocki · 2019-12-31T16:31:18Z

i get an exception when testing the mgmt command

root@7748ecbafc92:/code/app# ./manage.py send_tax_report
Traceback (most recent call last):
  File "./manage.py", line 59, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.6/dist-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.6/dist-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.6/dist-packages/django/core/management/base.py", line 323, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.6/dist-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/code/app/marketing/management/commands/send_tax_report.py", line 338, in handle
    zip_file_path = zip_dir(p.username, username_path)
  File "/code/app/marketing/management/commands/send_tax_report.py", line 236, in zip_dir
    zipf.write(abs_path, abs_path.split('code/tax_report')[1])
IndexError: list index out of range

owocki · 2019-12-31T16:34:14Z

app/marketing/views.py

+
+    if request.POST:
+
+        if 'preferred_payout_address' in request.POST.keys():


do we need all of these other settings inside of the tax settings update method?

Hi @owocki , I left them in this method because i see them in many other setting methods. I can remove this code part without problems.

i think remove them. if its copy/pasted elsewhere then thats something that should be removed in another PR

owocki · 2019-12-31T16:34:48Z

app/retail/templates/settings/tax.html

+<script>
+  var csrftoken = jQuery("[name=csrfmiddlewaretoken]").val();
+</script>
+<script async defer src="https://maps.googleapis.com/maps/api/js?key=AIzaSyBaJ6gEXMqjw0Y7d5Ps9VvelzOOvfV6BvQ&libraries=places&callback=initPlacecomplete"></script>


might make sense to move the API KEY somewhere else to DRY it??

Hi, i just copied the approach used in job.html. how would you like to do it ?

I moved the api key on backend view. do you agree or you mean something different. sorry if i did not understand it.

owocki · 2019-12-31T16:35:09Z

just read through the code; excited for this :)

PumpkingWok · 2019-12-31T18:31:20Z

Hi @owocki ,
for the issue regard list index out of range, i assumed that the root path is code, testing it via docker. I'm going to fix it in these days. Sorry.

PumpkingWok · 2020-01-02T19:18:06Z

Hi @owocki ,
I just committed and forced the rebase because i thought that there were some migrations to do (travis-ci failed) but even after the rebase the test failed again.I checked and it seems to failed in another command, test_assemble_leaderboards.py.

frankchen07 · 2020-03-06T18:46:33Z

@PumpkingWok - thanks for the work, I've paid you out! Let me know if you got it.

PumpkingWok · 2020-03-07T06:47:01Z

Hi there,
Thanks a lot for everything, I got the payment.

I'm so sorry if it took so much time, it needs to be tested and maybe there could be very few fixes to do. If it is too late for this year, to calculate tax, we can keep in contact and i could refactor it for the next year, during this year. let me know.

Thank you very much in any case. have a nice weekend !!!

thelostone-mc · 2020-04-21T00:16:47Z

@frankchen07 / @owocki Do we wanna get this in now or would it make sense to get a new PR setup with all the changes (if any needed) when it's needed ?

owocki · 2020-04-21T13:23:10Z

id love to get it in before 2021... but its not urgent before then (only to the extent that the code might get stale and merge conflicts and pumpkingwok might move on to other things).. i believe i've already paid andrea

…

On Mon, Apr 20, 2020 at 6:16 PM Aditya Anand M C ***@***.***> wrote: @frankchen07 <https://github.com/frankchen07> / @owocki <https://github.com/owocki> Do we wanna get this in now or would it make sense to get a new PR setup with all the changes (if any needed) when it's needed ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5072 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCJGGB4XE25IXQDDEULRNTQXXANCNFSM4IPPG7HQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $4.0mm for Open Source Software - see our results <https://gitcoin.co/results>

PumpkingWok · 2020-04-21T13:51:06Z

Hi there, @frankchen07 already tipped me via gitcoin.
If you need help to migrate it for manage next year taxes, feel free to contact me without problems, thanks in advance.

thelostone-mc · 2020-04-25T03:42:02Z

@PumpkingWok I've resolved the conflcts but could you

recreate the migration file (to avoid squash migrations)
it seems like you've added in a bunch of pdf files under misc_1099_templates
Are those needed ?

PumpkingWok · 2020-04-28T08:21:28Z

Hi @thelostone-mc,
I'm so sorry for the late reply.

I can look in it during this week
In misc_1099_templates there are 4 templates, copy_1, copy_2, copy_b, copy_c.
All of them will be filled with the same data. I talked with @owocki while i was developing this command, and i understood it, correct me if i'm wrong.
I retrieved the templates from https://www.irs.gov/pub/irs-pdf/f1099msc.pdf (copy_a was provided in form only for informational purpose)

Also you could read more details about this issue in #4806
For any doubt, please feel free to contact me. Thanks in advance.

thelostone-mc · 2020-04-28T08:24:24Z

Ah gotcha ! Thanks for clarifying it
If you could recreate the migration file + fix conflicts
I can get this in :)

thelostone-mc · 2020-04-29T14:49:05Z

@PumpkingWok could we try & get this in next week ? ^_^

PumpkingWok · 2020-04-29T15:25:47Z

Hi @thelostone-mc,
Do you mean if i can resolve the conflicts here with a rebase, as I always did while i was working on this PR ? Also i would recreate a new migration file for db. Thanks

thelostone-mc · 2020-05-03T03:57:46Z

@PumpkingWok yup! I'll add this back to review for wed deploy!
Would be stoked if you could resolve the conflicts + recreate migration file by then

PumpkingWok · 2020-05-03T09:42:52Z

Hi there,
@thelostone-mc, I could fix it tomorrow, during the day. Is it ok for you ?
Thanks in advance.

PumpkingWok · 2020-05-05T21:21:48Z

Hi @thelostone-mc,
ok, i have done it, i resolved the migration conflicts two times because i did not notice that you commited new migration files during the day.
For any doubt feel free to contact me without problems.
If you prefer, at the end, i can squash all commits into one. Thanks in advance.

thelostone-mc · 2020-05-07T13:17:08Z

@PumpkingWok nah i'll squash it at my end !
We're just rolling out some big changes this week so once those are stable -> I'll get this in

Appreciate it :)

PumpkingWok requested review from danlipert, octavioamu and thelostone-mc as code owners August 26, 2019 12:39

PumpkingWok changed the title ~~frontend/backend tax settings~~ [WIP] Add tax management Aug 26, 2019

PumpkingWok force-pushed the issue/4806 branch from 2572c6e to bc2c8db Compare August 26, 2019 13:31

PumpkingWok force-pushed the issue/4806 branch from 2eeaddd to 388d971 Compare September 3, 2019 17:00

PumpkingWok force-pushed the issue/4806 branch from 6d7935e to 321bc83 Compare November 2, 2019 17:51

PumpkingWok force-pushed the issue/4806 branch from 321bc83 to 41df548 Compare November 23, 2019 14:32

PumpkingWok force-pushed the issue/4806 branch from 41df548 to 10612fc Compare November 30, 2019 14:57

PumpkingWok force-pushed the issue/4806 branch from b2f2ae7 to 2da7547 Compare December 12, 2019 21:07

owocki mentioned this pull request Dec 16, 2019

as a funder, i want the abililty to issue 1099s for the work i've had done on the platform, because tax compliance #4806

Closed

owocki reviewed Dec 16, 2019

View reviewed changes

owocki reviewed Dec 31, 2019

View reviewed changes

PumpkingWok force-pushed the issue/4806 branch from 4b6c651 to 6c93b0b Compare January 2, 2020 19:08

Merge branch 'master' into issue/4806

392fdd0

PumpkingWok force-pushed the issue/4806 branch from df124d4 to 392fdd0 Compare May 4, 2020 17:43

PumpkingWok added 4 commits May 5, 2020 13:02

Merge branch 'master' into issue/4806

2813c1a

fix migration file

e4032cd

Merge branch 'master' into issue/4806

8595492

fix migration file to sync with master

442d86a

thelostone-mc and others added 3 commits May 13, 2020 13:59

Merge branch 'master' into issue/4806

f638c1f

Merge branch 'master' into issue/4806

962939d

Merge branch 'master' into issue/4806

dd1bfe9

danlipert approved these changes May 13, 2020

View reviewed changes

thelostone-mc approved these changes May 13, 2020

View reviewed changes

thelostone-mc added 2 commits May 22, 2020 12:55

Merge remote-tracking branch 'upstream/master' into issue/4806

410cda2

migrations

1f4e302

thelostone-mc merged commit 2578544 into gitcoinco:master May 22, 2020


		if request.POST:

		if 'preferred_payout_address' in request.POST.keys():

Add tax management #5072

Add tax management #5072

Conversation

PumpkingWok commented Aug 26, 2019 • edited Loading

Description

Refers/Fixes

Testing

codecov bot commented Aug 26, 2019

Codecov Report

codecov bot commented Aug 26, 2019 • edited Loading

Codecov Report

PumpkingWok commented Dec 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Dec 16, 2019

owocki commented Dec 18, 2019 via email

PumpkingWok commented Dec 19, 2019

owocki commented Dec 19, 2019 via email

PumpkingWok commented Dec 21, 2019

PumpkingWok commented Dec 30, 2019

owocki commented Dec 31, 2019

owocki commented Dec 31, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Dec 31, 2019

PumpkingWok commented Dec 31, 2019

PumpkingWok commented Jan 2, 2020

frankchen07 commented Mar 6, 2020

PumpkingWok commented Mar 7, 2020

thelostone-mc commented Apr 21, 2020

owocki commented Apr 21, 2020 via email

PumpkingWok commented Apr 21, 2020

thelostone-mc commented Apr 25, 2020

PumpkingWok commented Apr 28, 2020

thelostone-mc commented Apr 28, 2020 • edited Loading

thelostone-mc commented Apr 29, 2020 • edited Loading

PumpkingWok commented Apr 29, 2020

thelostone-mc commented May 3, 2020

PumpkingWok commented May 3, 2020

PumpkingWok commented May 5, 2020

thelostone-mc commented May 7, 2020

PumpkingWok commented Aug 26, 2019 •

edited

Loading

codecov bot commented Aug 26, 2019 •

edited

Loading

thelostone-mc commented Apr 28, 2020 •

edited

Loading

thelostone-mc commented Apr 29, 2020 •

edited

Loading