Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Job Details Bug Fix #5071

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Show Job Details Bug Fix #5071

merged 4 commits into from
Sep 10, 2019

Conversation

androolloyd
Copy link
Contributor

When users opt out of having their job details displayed, the API did not adhere to this.

dashboard.views

  • users_fetch
    • added a check to determine if the user has opted out
    • removing the job related keys from the output

	- when a user has turned show_job_status it will no longer show in the api
thelostone-mc
thelostone-mc previously approved these changes Aug 26, 2019
@thelostone-mc
Copy link
Member

@androolloyd looks like the tests need to be updated too

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #5071 into master will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5071      +/-   ##
==========================================
+ Coverage   30.86%   30.87%   +<.01%     
==========================================
  Files         219      218       -1     
  Lines       17656    17519     -137     
  Branches     2435     2405      -30     
==========================================
- Hits         5450     5409      -41     
+ Misses      11983    11892      -91     
+ Partials      223      218       -5
Impacted Files Coverage Δ
app/dashboard/views.py 13.16% <25%> (-0.81%) ⬇️
app/economy/utils.py 80.76% <0%> (-3.11%) ⬇️
app/dashboard/models.py 55.87% <0%> (-0.56%) ⬇️
app/marketing/views.py 11.85% <0%> (-0.05%) ⬇️
app/app/urls.py 89.36% <0%> (ø) ⬆️
...arketing/management/commands/export_graph_edges.py
app/retail/emails.py 23.59% <0%> (+0.02%) ⬆️
app/retail/utils.py 10.18% <0%> (+0.05%) ⬆️
app/marketing/mails.py 14.36% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec23f01...3f01c40. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #5071 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5071      +/-   ##
==========================================
- Coverage    30.9%   30.87%   -0.03%     
==========================================
  Files         219      219              
  Lines       17683    17660      -23     
  Branches     2437     2436       -1     
==========================================
- Hits         5465     5453      -12     
+ Misses      11994    11981      -13     
- Partials      224      226       +2
Impacted Files Coverage Δ
app/dashboard/views.py 14.13% <75%> (-0.13%) ⬇️
app/retail/helpers.py 28.57% <0%> (-42.86%) ⬇️
app/kudos/views.py 21.59% <0%> (-1.15%) ⬇️
app/dashboard/models.py 56.42% <0%> (-0.03%) ⬇️
app/retail/views.py 29.26% <0%> (ø) ⬆️
app/dashboard/router.py 35.93% <0%> (ø) ⬆️
app/grants/views.py 14.78% <0%> (ø) ⬆️
app/marketing/views.py 11.9% <0%> (+0.15%) ⬆️
app/retail/emails.py 23.57% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0019d2...66f0157. Read the comment docs.

@danlipert danlipert merged commit 952f437 into master Sep 10, 2019
@androolloyd androolloyd deleted the bug-fix/4868 branch September 12, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants