Adds hackathon results to /results page #5069
Conversation
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
app/kudos/kudos.yaml
Outdated
| @@ -5118,3 +5118,11 @@ | |||
| - Friends | |||
| - Love | |||
| image: 3box_butterfly.svg | |||
| - name: DAI | |||
There was a problem hiding this comment.
i dont know why this is on my PR. it already exists on master.
There was a problem hiding this comment.
😓 Is github UI messed up again
There was a problem hiding this comment.
Github has been letting us down lately... :(
There was a problem hiding this comment.
Updating the PR w/ Master fixed it somehow...
Codecov Report
@@ Coverage Diff @@
## master #5069 +/- ##
==========================================
- Coverage 31.01% 31.01% -0.01%
==========================================
Files 218 218
Lines 17531 17538 +7
Branches 2411 2413 +2
==========================================
+ Hits 5437 5439 +2
- Misses 11871 11874 +3
- Partials 223 225 +2
Continue to review full report at Codecov.
|
|
is this ok to merge? looks like it was approved but somehow didnt make the release... |
|
@octavioamu does this look good to you? |
There was a problem hiding this comment.
The code looks good to me, I tried to run in my locally but even running create_page_cache and changing manually to check rinkeby bounties, wasn't able to get any hackathon on results page (looks like the command need some data I don't have).
Anyway I saw the information about stats on the hackathon event in admin.
Description
Adds hackathon results to /results page
#4944
Refers/Fixes
Testing
tested locallly: