Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: email setup no applicant bounty #5062

Merged
merged 4 commits into from
Sep 3, 2019
Merged

chore: email setup no applicant bounty #5062

merged 4 commits into from
Sep 3, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 23, 2019

Description
Refers/Fixes

#5035

Testing

Video URL : https://embed.vidyard.com/share/ikLCZWvSek5HCNjTya5BZZ?

Navigate to http://localhost:8000/_administration/email/no_applicant_reminder to view mail

image

Dan: Tested 3/7 day selection query on prod

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1cb0949). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5062   +/-   ##
========================================
  Coverage          ?   31.8%           
========================================
  Files             ?     218           
  Lines             ?   17897           
  Branches          ?    2506           
========================================
  Hits              ?    5692           
  Misses            ?   11973           
  Partials          ?     232
Impacted Files Coverage Δ
app/app/urls.py 89.36% <ø> (ø)
app/retail/emails.py 23.57% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb0949...b6e0a96. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #5062 into master will decrease coverage by 0.31%.
The diff coverage is 13.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5062      +/-   ##
==========================================
- Coverage   31.03%   30.72%   -0.32%     
==========================================
  Files         218      218              
  Lines       17515    18084     +569     
  Branches     2404     2600     +196     
==========================================
+ Hits         5436     5556     +120     
- Misses      11856    12274     +418     
- Partials      223      254      +31
Impacted Files Coverage Δ
app/app/urls.py 89.36% <ø> (ø) ⬆️
app/retail/emails.py 23.57% <20%> (-0.03%) ⬇️
app/marketing/mails.py 14.26% <8.33%> (-0.11%) ⬇️
app/dashboard/views.py 16.13% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af472b6...7f286ba. Read the comment docs.

def render_no_applicant_reminder(bounty):
params = {
'bounty': bounty,
'directory_link': '/users?skills=' + bounty.keywords.lower()
Copy link
Member Author

@thelostone-mc thelostone-mc Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octavioamu / @PixelantDesign so if the bounty has keywords Python, javascript, MySQL , Moloch
The button would redirect to all those filters being applied => and no users would be shown as we would be searching for user who has all those 4 skills (especially Moloch)

We could match this against an exhaustive list at our end but even then we would end up with 3 skillm Python, javascript, MySQL and we might not have users with all 3 filters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is ok, since the skills needed are that. The users search will open without results and then the user can remove skills and filter new stuff to match the ones he need.

text,
html,
from_name="No Reply from Gitcoin.co",
categories=['marketing', func_name()],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this should be transactional.

idx_status='open',
)

for bounty in [b for b in bounties if b.no_of_applicants == 0]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool this will solve contest bounties.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cooool

@thelostone-mc thelostone-mc merged commit f6d84e2 into master Sep 3, 2019
@thelostone-mc thelostone-mc deleted the no_applicant branch June 27, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants