Invite users to a bounty based on skills #5060

danlipert · 2019-08-23T14:56:53Z

Description

Refers/Fixes

#5045

Testing

Tested locally with all filters, getting emails with invites perfectly according to the query

thelostone-mc · 2019-08-23T19:42:42Z

left a comment over at #5048 (comment)

app/dashboard/views.py

codecov · 2019-09-06T05:39:31Z

Codecov Report

❗ No coverage uploaded for pull request base (master@1cb0949). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5060   +/-   ##
=========================================
  Coverage          ?   18.57%           
=========================================
  Files             ?      206           
  Lines             ?    15985           
  Branches          ?     2162           
=========================================
  Hits              ?     2969           
  Misses            ?    13006           
  Partials          ?       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb0949...45dc8ad. Read the comment docs.

codecov · 2019-09-06T05:39:31Z

Codecov Report

Merging #5060 into master will decrease coverage by 0.03%.
The diff coverage is 37.28%.

@@            Coverage Diff             @@
##           master    #5060      +/-   ##
==========================================
- Coverage   30.78%   30.75%   -0.04%     
==========================================
  Files         221      221              
  Lines       17829    17958     +129     
  Branches     2464     2530      +66     
==========================================
+ Hits         5489     5523      +34     
- Misses      12114    12195      +81     
- Partials      226      240      +14

Impacted Files	Coverage Δ
app/app/settings.py	`78.96% <ø> (ø)`	⬆️
app/app/urls.py	`89.36% <ø> (ø)`	⬆️
app/dashboard/views.py	`14.23% <37.28%> (-0.06%)`	⬇️
app/app/middleware.py	`41.17% <0%> (-35.3%)`	⬇️
...rketing/management/commands/no_applicants_email.py	`0% <0%> (ø)`	⬆️
app/marketing/mails.py	`17.01% <0%> (+2.74%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5a548...2b69f46. Read the comment docs.

app/dashboard/views.py

octavioamu · 2019-09-18T23:56:26Z

@danlipert @thelostone-mc When reviewing check the users_fetch_filters also, for some reason github is not showing diff there, but the def was introduced in this PR

is done

thelostone-mc · 2019-09-19T05:43:59Z

app/dashboard/views.py

+    else:
+        profile_list = Profile.objects.prefetch_related(
+                'fulfilled', 'leaderboard_ranks', 'feedbacks_got'
+            ).exclude(hide_profile=True)


Oh why did we move this from def users_fetch_filters ? to keep that more generic ?

To be DRY instead of copy paste the same filters, both users filters and bulk invite user users_fetch_filters to filter and have the same result

thelostone-mc · 2019-09-19T06:07:16Z

app/assets/v2/js/users.js

+        return;
+      }
+      vm.issueDetails = undefined;
+      let getIssue = fetchData(apiUrldetails, 'GET');


thelostone-mc · 2019-09-19T06:07:23Z

app/assets/v2/js/users.js

+    },
+    getIssueDetails: function(url) {
+      let vm = this;
+      let apiUrldetails = `/actions/api/v0.1/bounties/?github_url=${encodeURIComponent(url)}`;


danlipert

Looking good, just a few comments and some potential fix we'll have to make in the future

danlipert · 2019-09-19T11:25:44Z

app/dashboard/views.py

@@ -1145,6 +1164,77 @@ def social_contribution_modal(request):
    return TemplateResponse(request, 'social_contribution_modal.html', params)


+@csrf_exempt


should we add the @staff_member_required decorator here to restrict access?

humm can be, Im restricting it using request.user.is_staff, seems to me there are plans to do this a feature for users so not sure if worst changing it.

danlipert · 2019-09-19T11:26:08Z

app/dashboard/views.py

+            bounty_invite.bounty.add(bounty)
+            bounty_invite.inviter.add(inviter)
+            bounty_invite.invitee.add(profile.user)
+            # emails.append(profile.email)


leftover line

danlipert · 2019-09-19T11:28:34Z

app/dashboard/views.py

+            # emails.append(profile.email)
+            try:
+                msg = request.POST.get('msg', '')
+                share_bounty([profile.email], msg, inviter.profile, invite_url, False)


I wonder how many emails we can send within the request-response window before the request times out? I'm guessing this will be somewhat buggy, may have to refactor to use celery soon but for now we'll see since its internal only.

…kill-based-invites

initial scaffold

cae78b8

danlipert mentioned this pull request Aug 23, 2019

Invite Groups of Contributors Based on Skills #5048

Closed

4 tasks

thelostone-mc reviewed Aug 26, 2019

View reviewed changes

app/dashboard/views.py Outdated Show resolved Hide resolved

chore: wiring up UI

4ef41a7

thelostone-mc force-pushed the skill-based-invites branch from 45dc8ad to 4ef41a7 Compare September 6, 2019 10:07

octavioamu added 3 commits September 6, 2019 19:07

fix select2 reset

14656e4

add conditions and security

7c1cc5a

fix multiple modals

afefead

octavioamu suggested changes Sep 10, 2019

View reviewed changes

app/dashboard/views.py Outdated Show resolved Hide resolved

add url, change name and fix sending data

2eb2835

octavioamu previously requested changes Sep 10, 2019

View reviewed changes

app/dashboard/views.py Show resolved Hide resolved

octavioamu and others added 11 commits September 9, 2019 23:28

add desc and checks

c140fdf

issue details fetcher

58147cb

add loading

619fa9e

add conditions and error feedback

be8b094

Merge branch 'master' into skill-based-invites

0178cfe

adding missing import + var

c676d6b

fix send

34d7d4b

add query for bulk invite

640a913

fix eslint

4c1da1d

remove prints

23c4c92

add space

0e8d97e

octavioamu marked this pull request as ready for review September 18, 2019 23:51

thelostone-mc reviewed Sep 19, 2019

View reviewed changes

Merge branch 'master' into skill-based-invites

defb188

danlipert commented Sep 19, 2019

View reviewed changes

octavioamu added 2 commits September 19, 2019 09:50

review changes

623a6c0

Merge branch 'skill-based-invites' of github.com:gitcoinco/web into s…

2b69f46

…kill-based-invites

thelostone-mc approved these changes Sep 19, 2019

View reviewed changes

thelostone-mc merged commit 4731117 into master Sep 19, 2019

thelostone-mc deleted the skill-based-invites branch June 27, 2020 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Invite users to a bounty based on skills #5060

Invite users to a bounty based on skills #5060

danlipert commented Aug 23, 2019 •

edited by octavioamu

Loading

thelostone-mc commented Aug 23, 2019

codecov bot commented Sep 6, 2019

codecov bot commented Sep 6, 2019 •

edited

Loading

octavioamu commented Sep 18, 2019

thelostone-mc Sep 19, 2019

octavioamu Sep 19, 2019

thelostone-mc Sep 19, 2019

thelostone-mc Sep 19, 2019

danlipert left a comment

danlipert Sep 19, 2019

octavioamu Sep 19, 2019

danlipert Sep 19, 2019

danlipert Sep 19, 2019

		@@ -1145,6 +1164,77 @@ def social_contribution_modal(request):
		return TemplateResponse(request, 'social_contribution_modal.html', params)


		@csrf_exempt

Invite users to a bounty based on skills #5060

Invite users to a bounty based on skills #5060

Conversation

danlipert commented Aug 23, 2019 • edited by octavioamu Loading

Description

Refers/Fixes

Testing

thelostone-mc commented Aug 23, 2019

codecov bot commented Sep 6, 2019

Codecov Report

codecov bot commented Sep 6, 2019 • edited Loading

Codecov Report

octavioamu commented Sep 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danlipert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danlipert commented Aug 23, 2019 •

edited by octavioamu

Loading

codecov bot commented Sep 6, 2019 •

edited

Loading