Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon onboard #5056

Merged
merged 4 commits into from
Sep 4, 2019
Merged

Hackathon onboard #5056

merged 4 commits into from
Sep 4, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Aug 22, 2019

Description

This is all automatically generated when a hackathon explorer is created, admin doesn't need to edit anything.
The onboard guide is the "door" of a hackathon, we want every user new or veteran to go there and understand the hackathon flow.

Logged user

Page dynamically generated for each hackathon explorer following branding.
image

Not logged / new user

Not logged users or new users first logging
image

Start/work via gitcoin

Open a modal with more details.
image

Submit plan plan for hackathon
The link go to the onboard guide and the message ask for repo and teams usernames
image

"how to participate" CTA in hackathon explorer
Link to onboard guide of that hackathon, before people start we want them to understand the hackathon rules
image

Join button when the hackathon still valid
If the hackathon date is already expired then hide the onboard link of that hackathon.
image

Refers/Fixes

fix #5039

Testing

@octavioamu octavioamu requested review from danlipert, thelostone-mc and owocki and removed request for danlipert and owocki August 22, 2019 05:59
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #5056 into master will increase coverage by 0.18%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5056      +/-   ##
==========================================
+ Coverage   30.87%   31.06%   +0.18%     
==========================================
  Files         219      219              
  Lines       17649    19177    +1528     
  Branches     2435     2870     +435     
==========================================
+ Hits         5449     5957     +508     
- Misses      11977    12933     +956     
- Partials      223      287      +64
Impacted Files Coverage Δ
app/app/urls.py 83.92% <ø> (-5.44%) ⬇️
app/dashboard/views.py 15.29% <9.09%> (+1.32%) ⬆️
app/retail/emails.py 23.95% <0%> (+0.38%) ⬆️
app/economy/utils.py 84.44% <0%> (+0.57%) ⬆️
app/marketing/views.py 12.84% <0%> (+0.94%) ⬆️
app/dashboard/models.py 57.92% <0%> (+1.5%) ⬆️
app/marketing/mails.py 16.91% <0%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5374e64...e186333. Read the comment docs.

@octavioamu
Copy link
Contributor Author

@octavioamu octavioamu marked this pull request as ready for review September 3, 2019 17:08
{{ hackathon.start_date|date:"M j, Y" }} - {{ hackathon.end_date|date:"M j, Y" }}

</div>
<!-- {% include 'shared/minihero.html' with h1=hackathon.name suppress_logo=1 position_h1_below_logo=True hide_rain=True %} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this ?

{% endif %}
<div class="row py-5">
<div class="col-12">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line ? :P

background: {% firstof hackathon.background_color or 'white' %};
color: {% firstof hackathon.text_color or 'black' %};
}
</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent fix?

@thelostone-mc thelostone-mc merged commit 96021fc into master Sep 4, 2019
@thelostone-mc thelostone-mc deleted the hackathon-onboard branch September 12, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants