adds the ability for phantom funding of a grant #5054

owocki · 2019-08-21T17:31:32Z

Description

adds the ability for phantom funding of a grant.

this allows anyone who is featured flagged to "signal" that they support a specific project.

so that we can get wider amount of contributions from the community, by skipping all the blockchain-ey parts.

to go live:

need list of usernames for feature flag
design cleanup
copy cleanup
kudos air drop after grant fulfill
v2 - script that actually includes these signals in the CLR calculations

Refers/Fixes

vivek was going to write a ticket, i dont think he has yet tho.

Testing

tested it locally.

owocki · 2019-08-22T09:06:08Z

what should we call this feature? https://gitcoincore.slack.com/archives/CBDTKB59A/p1566408751001400
‘value signals’
phantom contributions

vivek 8:34 PM
we will actually contribute on their behalf
maybe community contributions
so people don’t think they aren’t real contributions
?

codecov · 2019-08-23T11:02:30Z

Codecov Report

❗ No coverage uploaded for pull request base (master@787ebbd). Click here to learn what that means.
The diff coverage is 30.76%.

@@            Coverage Diff            @@
##             master    #5054   +/-   ##
=========================================
  Coverage          ?   30.88%           
=========================================
  Files             ?      220           
  Lines             ?    17752           
  Branches          ?     2446           
=========================================
  Hits              ?     5482           
  Misses            ?    12042           
  Partials          ?      228

Impacted Files	Coverage Δ
app/kudos/views.py	`22.67% <0%> (ø)`
app/marketing/admin.py	`83.56% <100%> (ø)`
app/grants/admin.py	`43.37% <100%> (ø)`
app/app/context.py	`50% <25%> (ø)`
app/marketing/models.py	`61.72% <80%> (ø)`
app/grants/models.py	`59.82% <83.33%> (ø)`
app/grants/views.py	`14.25% <9.09%> (ø)`
app/marketing/utils.py	`30.9% <9.09%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 787ebbd...0833579. Read the comment docs.

owocki · 2019-08-27T16:40:01Z

@vs77bb should you take this forward or should i?

@danlipert any comments on the existing code before we push it across the finish line?

danlipert · 2019-08-28T12:28:52Z

app/grants/models.py

@@ -900,3 +900,25 @@ class MatchPledge(SuperModel):
    def __str__(self):
        """Return the string representation of this object."""
        return f"{self.profile} <> {self.amount} DAI"
+
+class PhantomFunding(SuperModel):
+    """Define the structure of a subscription agreement."""


Can we add something that describes what this is for or why we created it? Looks like this is from a cut-and-paste job ;)

danlipert · 2019-08-28T12:31:01Z

app/grants/models.py

+        'grants.Grant',
+        related_name='phantom_funding',
+        on_delete=models.CASCADE,
+        help_text=_('The associated Phantom Funding.'),


Change help text to something like The grant being Phantom funded

danlipert · 2019-08-28T12:31:19Z

app/grants/models.py

+        'dashboard.Profile',
+        related_name='grant_phantom_funding',
+        on_delete=models.CASCADE,
+        help_text=_('The associated Phantom Funding.'),


Change help text to The user profile creating the Phantom Funding

owocki · 2019-08-30T15:27:16Z

any more feedback? @danlipert -- @vs77bb is pestering me to get this live

…-add a user to a group based upon a link

owocki · 2019-09-04T15:29:19Z

@gitcoinco/engineers ?? cc @vs77bb

owocki · 2019-09-04T16:03:59Z

app/grants/models.py

+
+    """
+
+    round_number = models.PositiveIntegerField(blank=True, null=True)


@frankchen07 this is the new model that will contain info about when people phantom fund.

two ways we can manage this:

you just build phantom funding into your existing reports

myself or engineering builds a finalize_phantom_funding job that runs once per round, at end of round, that
a. closes out phantom funding for that round
b. makes the phantom contribs into actual contributions (both on chain and in the DB)
c. anything else??

cc @danlipert 4 other ideas

I'm assuming the data model reflects this in a way where it's easy to build it into the reports. I think as long as it tell me the contributor, which grant(s) they've committed to and how much, it can be easily integrated into the report at the end of the CLR round.

from a product perspective, point number 2 is the trickier one, especially with As a funder I want to see previous contributions to projects and what my expected CLR match is #3663 - since this is part of the product update that vitalik requested (a nifty little feature that tells us in "real" time, how much potential a contribution has in the LR context, and this needs all the contributions, real and phantom in order to be the most accurate). I might be overthinking it in the sense that if the data exists it can be used in the feature, and the phantom_funding job is a completely separate "payout" related action at the end.

In a related conversation, Dan suggested that we do some kind of simplified calculation and cache the results so we can give them a range, since doing a live calculation with real data every time someone changes a number in an input box can be performance hell.

yea it does that (tho 'how much' is inferred by 5/(num_votes_cast_by_contrib)

hmm.. yeah As a funder I want to see previous contributions to projects and what my expected CLR match is #3663 does make it more complicated. ill add a note there about phantom funding.

agree with @danlipert s thoughts.

danlipert

Just 1 small thing and changing the toggle to a POST request to prevent CSRF/etc.

danlipert · 2019-09-09T14:02:58Z

app/grants/views.py

+    round_number = 3
+    can_phantom_fund = request.user.is_authenticated and request.user.groups.filter(name='phantom_funders').exists()
+    phantom_funds = PhantomFunding.objects.filter(profile=request.user.profile, grant=grant, round_number=round_number)
+    is_phantom_funding_this_grant = can_phantom_fund and request.user.is_authenticated and phantom_funds.exists()


extra auth check here already checked when can_phantom_fund is created

danlipert · 2019-09-09T14:04:05Z

app/grants/views.py

+    show_tweet_modal = False
+    if can_phantom_fund:
+        active_tab = 'phantom'
+    if can_phantom_fund and request.GET.get('toggle_phantom_fund'):


This we need to turn into a POST request so that it can't be exploited

owocki · 2019-09-09T16:44:43Z

@danlipert just fixed both your comments in 70bb11b

owocki · 2019-09-09T16:44:59Z

anyone else have feedback? this needs to go in weds release @enginneering

danlipert · 2019-09-09T17:07:14Z

@thelostone-mc @octavioamu Lets make sure we get this one in Wednesday

thelostone-mc

code wise lgtm !
Need to re-indent stuff but yeah

adds thte ability for phantom funding of a grant

ac6f7dc

owocki requested review from danlipert, octavioamu and thelostone-mc as code owners August 21, 2019 17:31

owocki changed the title ~~adds the ability for phantom funding of a grant~~ WIP - adds the ability for phantom funding of a grant Aug 22, 2019

linter

33c5e94

danlipert suggested changes Aug 28, 2019

View reviewed changes

owocki added 3 commits August 28, 2019 14:16

code review

ac41d15

grant signalling

c2dafab

grant signalling

81e8513

owocki changed the title ~~WIP - adds the ability for phantom funding of a grant~~ adds the ability for phantom funding of a grant Aug 29, 2019

owocki added 3 commits August 30, 2019 09:42

enables tweet about grant again

47a3750

adds the ability to do custom marketing callbacks so that we can auto…

b904a47

…-add a user to a group based upon a link

only add user to group if authenticated

61b8037

owocki commented Sep 4, 2019

View reviewed changes

virality on the post grant fund modal

8121c36

owocki mentioned this pull request Sep 5, 2019

As a funder I want to see previous contributions to projects and what my expected CLR match is #3663

Closed

3 tasks

danlipert suggested changes Sep 9, 2019

View reviewed changes

DL fixes

70bb11b

Merge branch 'master' into kevin/phantom_funding

8450dc2

danlipert approved these changes Sep 9, 2019

View reviewed changes

Merge branch 'master' into kevin/phantom_funding

09320f8

thelostone-mc approved these changes Sep 11, 2019

View reviewed changes

octavioamu approved these changes Sep 11, 2019

View reviewed changes

octavioamu added 2 commits September 11, 2019 11:41

Merge branch 'master' into kevin/phantom_funding

2f51e7f

Merge branch 'master' into kevin/phantom_funding

0833579

octavioamu merged commit 3e3871e into master Sep 11, 2019

thelostone-mc deleted the kevin/phantom_funding branch June 27, 2020 00:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds the ability for phantom funding of a grant #5054

adds the ability for phantom funding of a grant #5054

owocki commented Aug 21, 2019 •

edited

Loading

owocki commented Aug 22, 2019

codecov bot commented Aug 23, 2019 •

edited

Loading

owocki commented Aug 27, 2019

danlipert Aug 28, 2019

owocki Aug 28, 2019

danlipert Aug 28, 2019

owocki Aug 28, 2019

danlipert Aug 28, 2019

owocki Aug 28, 2019

owocki commented Aug 30, 2019

owocki commented Sep 4, 2019

owocki Sep 4, 2019

frankchen07 Sep 5, 2019

owocki Sep 5, 2019

danlipert left a comment

danlipert Sep 9, 2019

owocki Sep 9, 2019

danlipert Sep 9, 2019

owocki Sep 9, 2019

owocki commented Sep 9, 2019

owocki commented Sep 9, 2019

danlipert commented Sep 9, 2019

thelostone-mc left a comment •

edited

Loading


		"""

		round_number = models.PositiveIntegerField(blank=True, null=True)

adds the ability for phantom funding of a grant #5054

adds the ability for phantom funding of a grant #5054

Conversation

owocki commented Aug 21, 2019 • edited Loading

Description

Refers/Fixes

Testing

owocki commented Aug 22, 2019

codecov bot commented Aug 23, 2019 • edited Loading

Codecov Report

owocki commented Aug 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Aug 30, 2019

owocki commented Sep 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danlipert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Sep 9, 2019

owocki commented Sep 9, 2019

danlipert commented Sep 9, 2019

thelostone-mc left a comment • edited Loading

Choose a reason for hiding this comment

owocki commented Aug 21, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019 •

edited

Loading

thelostone-mc left a comment •

edited

Loading