Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open users with skill filter #5047

Merged
merged 3 commits into from
Aug 21, 2019
Merged

feat: open users with skill filter #5047

merged 3 commits into from
Aug 21, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 20, 2019

Description

http://localhost:8000/users?skills=html,PHP activates the filters and it works as expected

Refers/Fixes

closes #5014

Test

https://embed.vidyard.com/share/7ksCTEBQJc6C3BEZGXF4mb?

@octavioamu
Copy link
Contributor

@thelostone-mc the problem was in vm.params.skills = skills.split(','); as that deep object assignment is not reactive. So the solution is in that scenarios using set vm.$set(vm.params, 'skills', skills.split(',')); and problem solved.
I made a few changes to make this feature available to all the filters so now can be set by url like http://localhost:8000/users?skills=css,javascript&bounties_completed=0,5

@thelostone-mc
Copy link
Member Author

Ahh got it from https://vuejs.org/v2/guide/reactivity.html#Change-Detection-Caveats! Niceee 🙌

@thelostone-mc thelostone-mc marked this pull request as ready for review August 21, 2019 11:08
@thelostone-mc thelostone-mc merged commit 9c58a67 into master Aug 21, 2019
@thelostone-mc thelostone-mc deleted the lulz branch June 27, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open user directory with custom skill filters applied
3 participants