Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hachathon list link and event tags #5044

Merged
merged 2 commits into from
Aug 21, 2019
Merged

add hachathon list link and event tags #5044

merged 2 commits into from
Aug 21, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Aug 20, 2019

Description

Add event data to bounty router
add hachathon list link to navbar
Add event tags to general explorer only
Add event tag to bounty detail
image

image

Refers/Fixes
Testing

Tested locally in explorer and hackathon explorer

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #5044 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5044      +/-   ##
==========================================
+ Coverage   30.89%   30.94%   +0.04%     
==========================================
  Files         218      217       -1     
  Lines       17476    17464      -12     
  Branches     2394     2393       -1     
==========================================
+ Hits         5400     5405       +5     
+ Misses      11856    11839      -17     
  Partials      220      220
Impacted Files Coverage Δ
app/dashboard/router.py 35.93% <100%> (+1.41%) ⬆️
...cet/management/commands/process_faucet_requests.py
app/marketing/views.py 11.89% <0%> (+0.03%) ⬆️
app/faucet/views.py 29.33% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b63315...b5cca37. Read the comment docs.

danlipert
danlipert previously approved these changes Aug 21, 2019
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two typos but then it will be good to go

app/assets/v2/js/pages/bounty_details.js Outdated Show resolved Hide resolved
app/dashboard/router.py Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc merged commit 2782940 into master Aug 21, 2019
@thelostone-mc thelostone-mc deleted the hackathon-link branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants