Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noscript content for seo #5042

Merged
merged 3 commits into from
Aug 28, 2019
Merged

add noscript content for seo #5042

merged 3 commits into from
Aug 28, 2019

Conversation

danlipert
Copy link
Contributor

Description

These changes add relevant bounty content to a noscript tag in the bounty detail page so that google has some idea of what is being rendered here. This is recommended by google here: https://support.google.com/webmasters/answer/66353

Refers/Fixes

#4848

Testing

Tested locally

Note in the screenshot, javascript is disabled. Without these changes, the page just shows the loading gif forever without any content being shown.

Screen Shot 2019-08-20 at 8 37 45 PM

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #5042 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5042      +/-   ##
==========================================
- Coverage   30.92%   30.92%   -0.01%     
==========================================
  Files         217      217              
  Lines       17459    17460       +1     
  Branches     2393     2393              
==========================================
  Hits         5400     5400              
  Misses      11839    11839              
- Partials      220      221       +1
Impacted Files Coverage Δ
app/dashboard/views.py 14% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3612036...c4afe16. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #5042 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5042      +/-   ##
==========================================
- Coverage   31.03%   30.91%   -0.12%     
==========================================
  Files         218      218              
  Lines       17515    17482      -33     
  Branches     2404     2394      -10     
==========================================
- Hits         5436     5405      -31     
- Misses      11856    11857       +1     
+ Partials      223      220       -3
Impacted Files Coverage Δ
app/dashboard/views.py 14% <0%> (-0.17%) ⬇️
app/dashboard/utils.py 37.12% <0%> (-3.61%) ⬇️
app/app/settings.py 78.81% <0%> (-0.16%) ⬇️
app/dashboard/models.py 57.02% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3586a50...e08033f. Read the comment docs.

@marc-at-consensys
Copy link

Great, Google should be able to see noscript content.

@danlipert danlipert merged commit 3b10e3a into master Aug 28, 2019
@thelostone-mc thelostone-mc deleted the noscript-bounty-content branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants