activity stream DRY & cleanup #5041
Conversation
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5041 +/- ##
=========================================
- Coverage 30.92% 30.9% -0.03%
=========================================
Files 217 217
Lines 17459 17474 +15
Branches 2393 2400 +7
=========================================
+ Hits 5400 5401 +1
- Misses 11839 11852 +13
- Partials 220 221 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5041 +/- ##
==========================================
- Coverage 30.89% 30.87% -0.03%
==========================================
Files 218 218
Lines 17476 17491 +15
Branches 2394 2401 +7
==========================================
+ Hits 5400 5401 +1
- Misses 11856 11870 +14
Partials 220 220
Continue to review full report at Codecov.
|
| {% elif row.metadata.grant_logo %} | ||
| <img class="avatar" src="{{ row.metadata.grant_logo }}" style="width: 30px; height: 30px; bottom: 0; right: 0; position: absolute;"/> | ||
| {% if row.secondary_avatar_url %} | ||
| <img class="avatar secondary_avatar" src="{{row.secondary_avatar_url}}" /> |
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| #activity_stream .avatar { | |||
| .activity_stream .avatar { | |||
| right: 0rem; | ||
| position: absolute; | ||
| } | ||
|
|
||
| .funder-avatar, | ||
| .activity-avatar { | ||
| text-align: center; | ||
| } | ||
|
|
||
| .funder-avatar, |
There was a problem hiding this comment.
this can be removed I think
There was a problem hiding this comment.
looks like this is the reason why travis is complaining
34:15 ✖ Unexpected empty block block-no-empty
There was a problem hiding this comment.
just pushed up a fix
…web into kevin/activity_stream_cleanup
Description
massive activity stream cleanup
/activitypage and the profile page. (5 files down to 1, and a bunch of deleted code! yay)Refers/Fixes
self
Testing
tested locally.. here is a screenshot