Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small time-saving operational tweaks for faucet request management #5029

Merged
merged 4 commits into from
Aug 20, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Aug 18, 2019

Description

small time-saving operational tweaks for faucet request management

  1. auto-reject requests with no comment
  2. prefills a few different rejection reasons
  3. after request fulfilled, forwards to list of requests to process instead of general admin)
Refers/Fixes

self

Testing

tested locally

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #5029 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
- Coverage   30.92%   30.89%   -0.03%     
==========================================
  Files         217      218       +1     
  Lines       17460    17476      +16     
  Branches     2393     2394       +1     
==========================================
  Hits         5400     5400              
- Misses      11840    11855      +15     
- Partials      220      221       +1
Impacted Files Coverage Δ
...cet/management/commands/process_faucet_requests.py 0% <0%> (ø)
app/faucet/views.py 28.57% <0%> (-0.77%) ⬇️
app/dashboard/views.py 14.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad45c9...faa8f5f. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #5029 into master will increase coverage by 1.53%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
+ Coverage   30.93%   32.46%   +1.53%     
==========================================
  Files         217      218       +1     
  Lines       17457    20315    +2858     
  Branches     2392     3184     +792     
==========================================
+ Hits         5400     6595    +1195     
- Misses      11837    13402    +1565     
- Partials      220      318      +98
Impacted Files Coverage Δ
...cet/management/commands/process_faucet_requests.py 0% <0%> (ø)
app/faucet/views.py 28.57% <0%> (-0.77%) ⬇️
app/app/urls.py 82.45% <0%> (-6.91%) ⬇️
app/dashboard/router.py 29.72% <0%> (-4.8%) ⬇️
app/grants/views.py 13.27% <0%> (-1.52%) ⬇️
app/dashboard/helpers.py 13.41% <0%> (-0.81%) ⬇️
...agement/commands/send_tips_for_bounty_fulfiller.py 0% <0%> (ø) ⬆️
app/dashboard/views.py 15.92% <0%> (+1.91%) ⬆️
app/retail/emails.py 26.37% <0%> (+2.78%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f411f21...1dfd064. Read the comment docs.

thelostone-mc
thelostone-mc previously approved these changes Aug 19, 2019
@thelostone-mc thelostone-mc merged commit 1b63315 into master Aug 20, 2019
@thelostone-mc thelostone-mc deleted the kevin/faucet_tweaks branch August 20, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants