Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bounty Payout Milestone 1-Review #5027
Bounty Payout Milestone 1-Review #5027
Changes from 29 commits
1c7ff31
4e3eabb
db6cedb
e5fc617
ddc28c2
8bde246
35b09c8
4450713
e8e5710
7f43a79
d78dbe6
526d8bb
3b53af3
8f47727
f141e7f
6db6e25
0cdec36
7f41c2a
508a81f
50b9516
bd3ce81
d5d0d64
d441edb
ef8d506
b2af37c
64c01a4
238e31a
77c6bb6
27e75bd
e8ee0b8
1831ab9
6dd7685
c8d192d
a3e1b1a
70c4192
4ff4d69
7166b6d
b5f05cd
01c2e6a
3fd2ce1
a03df45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ remove the if block ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, same as above, anytime we see a message key in the returning object, we want to log it and skip to the next element, the error's are vague but are only caused by a couple of things, permissions errors are the most prevelant