Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: sentry big fixes #5025

Merged
merged 4 commits into from
Aug 21, 2019
Merged

bug: sentry big fixes #5025

merged 4 commits into from
Aug 21, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 16, 2019

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #5025 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5025   +/-   ##
=======================================
  Coverage   30.93%   30.93%           
=======================================
  Files         217      217           
  Lines       17457    17457           
  Branches     2392     2392           
=======================================
  Hits         5400     5400           
  Misses      11837    11837           
  Partials      220      220

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f411f21...29880a7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #5025 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   30.89%   30.86%   -0.04%     
==========================================
  Files         218      218              
  Lines       17476    17476              
  Branches     2394     2394              
==========================================
- Hits         5400     5394       -6     
- Misses      11856    11862       +6     
  Partials      220      220
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b63315...5c42ed2. Read the comment docs.

@thelostone-mc thelostone-mc changed the title bug: fixes 0 of undefined bug: sentry big fixes Aug 16, 2019
danlipert
danlipert previously approved these changes Aug 19, 2019
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay

@thelostone-mc thelostone-mc merged commit be06406 into gitcoinco:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants