Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: remarket issue #5017

Merged
merged 1 commit into from
Aug 14, 2019
Merged

bug: remarket issue #5017

merged 1 commit into from
Aug 14, 2019

Conversation

thelostone-mc
Copy link
Member

Description

Set the last_remarket to current-time when it's None

@vince0656

Testing
  • locally tested

@thelostone-mc
Copy link
Member Author

There is also something neater we could do along the lines of

from django.utils.timezone import now
created_date = models.DateTimeField(default=now, editable=False)

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #5017 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5017   +/-   ##
=======================================
  Coverage   30.93%   30.93%           
=======================================
  Files         217      217           
  Lines       17457    17457           
  Branches     2392     2392           
=======================================
  Hits         5400     5400           
  Misses      11837    11837           
  Partials      220      220
Impacted Files Coverage Δ
app/dashboard/views.py 14.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079e0d4...1d76cc0. Read the comment docs.

@vince0656
Copy link
Contributor

I think the solution submitted in the PR is better than the second one suggested in the comment a we then only set last_remarketed when the bounty is actually being re_marketed :)

@thelostone-mc thelostone-mc merged commit 106146e into gitcoinco:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants