Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-surface an issue to the top of the issues explorer when its expiration has been extended #5012

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

vince0656
Copy link
Contributor

@vince0656 vince0656 commented Aug 13, 2019

Description

After extending the expiration of a bounty, this new code triggers the re-marketing functionality which in turn surfaces the bounty to the top of the issue explorer

Refers/Fixes

#4744

Testing

Unit tests have been appropriately added and local development testing has been done as per the demonstration video.

Video demonstration

https://drive.google.com/open?id=1x8mCrCLeynqUodhrpYOLnc4mmhuMYjPq

My laptop slowed down during recording but you can see that when expiration is extended, the issue is re-marketed to the top of the issue explorer

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #5012 into master will decrease coverage by 0.04%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5012      +/-   ##
==========================================
- Coverage   30.92%   30.87%   -0.05%     
==========================================
  Files         217      217              
  Lines       17402    17458      +56     
  Branches     2381     2394      +13     
==========================================
+ Hits         5382     5391       +9     
- Misses      11801    11847      +46     
- Partials      219      220       +1
Impacted Files Coverage Δ
app/dashboard/utils.py 37.12% <ø> (ø) ⬆️
app/dashboard/helpers.py 14.21% <ø> (ø) ⬆️
app/dashboard/router.py 34.51% <25%> (-0.31%) ⬇️
app/dashboard/views.py 14.04% <6.97%> (-0.2%) ⬇️
app/dashboard/models.py 57.06% <92.3%> (+0.26%) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa464a...46c3869. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #5012 into master will increase coverage by 0.14%.
The diff coverage is 73.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5012      +/-   ##
==========================================
+ Coverage   30.91%   31.06%   +0.14%     
==========================================
  Files         218      217       -1     
  Lines       17481    17478       -3     
  Branches     2394     2396       +2     
==========================================
+ Hits         5405     5430      +25     
+ Misses      11856    11825      -31     
- Partials      220      223       +3
Impacted Files Coverage Δ
app/dashboard/views.py 14.16% <0%> (+0.15%) ⬆️
app/app/settings.py 78.96% <100%> (+0.15%) ⬆️
app/dashboard/utils.py 40.73% <84.84%> (+3.6%) ⬆️
app/dashboard/router.py 34.51% <0%> (-1.42%) ⬇️
...cet/management/commands/process_faucet_requests.py
app/marketing/views.py 11.89% <0%> (+0.03%) ⬆️
app/faucet/views.py 29.33% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2782940...5ac4a68. Read the comment docs.

@thelostone-mc
Copy link
Member

@vince0656 you might have to remove the first commit as that's already ! Could you double check that ?

@vince0656
Copy link
Contributor Author

@thelostone-mc not sure why the PR didn't automatically pick up the commit from the merge of #4876 into master but it has now picked it up and is no longer showing that commit

@vince0656 vince0656 changed the title Extend resurface Re-surface an issue to the top of the issues explorer when its expiration has been extended Aug 18, 2019
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! Just one request to make this a bit easier to maintain and then I think we are all set

app/dashboard/utils.py Outdated Show resolved Hide resolved
@vince0656
Copy link
Contributor Author

@danlipert, this is ready to go again!

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change and then I think we're good to go

app/dashboard/tests/test_dashboard_utils.py Outdated Show resolved Hide resolved
@vince0656
Copy link
Contributor Author

@danlipert Good to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants