-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-surface an issue to the top of the issues explorer when its expiration has been extended #5012
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5012 +/- ##
==========================================
- Coverage 30.92% 30.87% -0.05%
==========================================
Files 217 217
Lines 17402 17458 +56
Branches 2381 2394 +13
==========================================
+ Hits 5382 5391 +9
- Misses 11801 11847 +46
- Partials 219 220 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5012 +/- ##
==========================================
+ Coverage 30.91% 31.06% +0.14%
==========================================
Files 218 217 -1
Lines 17481 17478 -3
Branches 2394 2396 +2
==========================================
+ Hits 5405 5430 +25
+ Misses 11856 11825 -31
- Partials 220 223 +3
Continue to review full report at Codecov.
|
@vince0656 you might have to remove the first commit as that's already ! Could you double check that ? |
46c3869
to
6e5b4b9
Compare
@thelostone-mc not sure why the PR didn't automatically pick up the commit from the merge of #4876 into master but it has now picked it up and is no longer showing that commit |
d1f67bc
to
985d2cb
Compare
985d2cb
to
e0f52c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job! Just one request to make this a bit easier to maintain and then I think we are all set
a6a1c50
to
9e80fc2
Compare
@danlipert, this is ready to go again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small change and then I think we're good to go
…ding its deadline
9e80fc2
to
54f630d
Compare
@danlipert Good to go 👍 |
Description
After extending the expiration of a bounty, this new code triggers the re-marketing functionality which in turn surfaces the bounty to the top of the issue explorer
Refers/Fixes
#4744
Testing
Unit tests have been appropriately added and local development testing has been done as per the demonstration video.
Video demonstration
https://drive.google.com/open?id=1x8mCrCLeynqUodhrpYOLnc4mmhuMYjPq
My laptop slowed down during recording but you can see that when expiration is extended, the issue is re-marketed to the top of the issue explorer