-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bounty/new: add new token model #5002
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5002 +/- ##
=======================================
Coverage 30.92% 30.92%
=======================================
Files 217 217
Lines 17402 17402
Branches 2381 2381
=======================================
Hits 5382 5382
Misses 11801 11801
Partials 219 219 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #5002 +/- ##
=======================================
Coverage 30.92% 30.92%
=======================================
Files 217 217
Lines 17402 17402
Branches 2381 2381
=======================================
Hits 5382 5382
Misses 11801 11801
Partials 219 219 Continue to review full report at Codecov.
|
@@ -223,9 +283,7 @@ $(function() { | |||
|
|||
|
|||
setTimeout(setUsdAmount, 1000); | |||
waitforWeb3(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed as it's not needed !
And having this here cause the occasional bug where the modal would popup before the page was ready 🤷♂
}; | ||
|
||
callMethodIfTokenIsAuthed(success, promptForAuthFailure); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved the above into new_bounty.js and refactored to make it into 2 neat functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
new_bounty.js
Fixes
closes #4984
Testing
Recording HERE