Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty/new: add new token model #5002

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 10, 2019

Description

  • refactors a good chunk of code to use Promises
  • moved token auth check from shared to new_bounty.js
  • added modal which asks funder to go to token page to enable token
  • modal is triggered when funder changes token in dropdown to token which isn't enabled
  • modal is also triggered if funder ignores that and attempts to fund an issue
Fixes

closes #4984

Testing
  • Created bounty with ETH & succeeded
  • Created bounty with an enabled ERC20 token & succeeded
  • Attempted to create a bounty with an ERC token which wasn't enabled and wasn't able to

Recording HERE

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #5002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5002   +/-   ##
=======================================
  Coverage   30.92%   30.92%           
=======================================
  Files         217      217           
  Lines       17402    17402           
  Branches     2381     2381           
=======================================
  Hits         5382     5382           
  Misses      11801    11801           
  Partials      219      219

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f6d94...5beff5c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #5002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5002   +/-   ##
=======================================
  Coverage   30.92%   30.92%           
=======================================
  Files         217      217           
  Lines       17402    17402           
  Branches     2381     2381           
=======================================
  Hits         5382     5382           
  Misses      11801    11801           
  Partials      219      219

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f6d94...5beff5c. Read the comment docs.

@@ -223,9 +283,7 @@ $(function() {


setTimeout(setUsdAmount, 1000);
waitforWeb3(function() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed as it's not needed !
And having this here cause the occasional bug where the modal would popup before the page was ready 🤷‍♂

};

callMethodIfTokenIsAuthed(success, promptForAuthFailure);
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the above into new_bounty.js and refactored to make it into 2 neat functions

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 1fa464a into gitcoinco:master Aug 13, 2019
@thelostone-mc thelostone-mc deleted the model branch January 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants