Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace showdown with highlight + markdown #4948

Merged
merged 6 commits into from
Aug 7, 2019

Conversation

thelostone-mc
Copy link
Member

Description
  • replaces showdown beta version with markdown-it stable version
  • added highlight.js for code snippet
  • fixed typos
Fixes

Closes #4916

Testing

screencapture-localhost-8000-issue-gnosis-mock-contract-14-2293-2019-08-03-20_12_17

@octavioamu
Copy link
Contributor

cool, this is working in funders/new also?

@thelostone-mc
Copy link
Member Author

Ah it doesn't !
I can throw in a follow up PR to get that fixed too

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #4948 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4948   +/-   ##
=======================================
  Coverage   30.83%   30.83%           
=======================================
  Files         217      217           
  Lines       17397    17397           
  Branches     2376     2376           
=======================================
  Hits         5365     5365           
  Misses      11815    11815           
  Partials      217      217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e231b2...5008110. Read the comment docs.

octavioamu
octavioamu previously approved these changes Aug 7, 2019
octavioamu
octavioamu previously approved these changes Aug 7, 2019
danlipert
danlipert previously approved these changes Aug 7, 2019
@thelostone-mc thelostone-mc dismissed stale reviews from danlipert and octavioamu via 8fd8cb6 August 7, 2019 15:38
@danlipert danlipert merged commit b4315d0 into gitcoinco:master Aug 7, 2019
@thelostone-mc thelostone-mc deleted the markdown branch January 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Bounties Gitcoin Bounties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with the formating on issue details page -GNOSIS BOUNTIES
3 participants