Bug/4817 abuse of invite system

[androolloyd]

Description

Removed invite_url from the JavaScript global scope
Removed invite_url from the share bounty client request
Removed invite_url from the share bounty server request handler

Refers/Fixes

#4817

Testing

Email's that are sent contain an invite_url generated correctly by the server

[codecov]

Codecov Report

Merging #4945 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4945      +/-   ##
==========================================
+ Coverage   30.63%   30.63%   +<.01%     
==========================================
  Files         216      216              
  Lines       17496    17494       -2     
  Branches     2389     2388       -1     
==========================================
  Hits         5360     5360              
+ Misses      11920    11917       -3     
- Partials      216      217       +1

Impacted Files	Coverage Δ
app/dashboard/views.py	14.21% <0%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43331e2...cf2045f. Read the comment docs.

[codecov]

Codecov Report

Merging #4945 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4945      +/-   ##
==========================================
+ Coverage   30.63%   30.63%   +<.01%     
==========================================
  Files         216      216              
  Lines       17496    17494       -2     
  Branches     2389     2388       -1     
==========================================
  Hits         5360     5360              
+ Misses      11920    11917       -3     
- Partials      216      217       +1

Impacted Files	Coverage Δ
app/dashboard/views.py	14.21% <0%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43331e2...cf2045f. Read the comment docs.

[androolloyd]

Not sure why codecoverage on my patch is coming in at 0, all i did was remove a couple of variables from global js scope and from the client/server request handler.

[thelostone-mc]

LGTM

[danlipert]

Not sure why codecoverage on my patch is coming in at 0, all i did was remove a couple of variables from global js scope and from the client/server request handler.

Don't worry about codecoverage, its more of a reminder to add coverage if appropriate