fixes tooltips on bounty detail pages #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4938 +/- ##
=======================================
Coverage 30.63% 30.63%
=======================================
Files 216 216
Lines 17491 17491
Branches 2386 2386
=======================================
Hits 5359 5359
+ Misses 11917 11916 -1
- Partials 215 216 +1
Continue to review full report at Codecov.
|
danlipert
previously approved these changes
Aug 2, 2019
| @@ -112,7 +112,11 @@ var heads = { | |||
| var callbacks = { | |||
| 'github_url': link_ize, | |||
| 'value_in_token': function(key, val, result) { | |||
| return [ 'amount', token_value_to_display(val) + ' ' + result['token_name'] ]; | |||
| var title = token_value_to_display(val) + ' ' + result['token_name']; | |||
| var title_expand = title + ' in funding from original funder.'; | |||
There was a problem hiding this comment.
@owocki I'm updating this to const just to be on the safer side + to avoid hoisting
thelostone-mc
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
piggybacks on #4930