Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow and check for regex in email suppression #4936

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

danlipert
Copy link
Contributor

Description

This change allows regexes to be used in the email suppression list, as well as checks for these regexes when syncing emails to and from mailchimp and our database.

Refers/Fixes

none

Testing

Tested locally

@danlipert
Copy link
Contributor Author

@owocki here's a fix that allows us to use the current suppression list, but also use regexes if we need to

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #4936 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4936      +/-   ##
==========================================
- Coverage   30.63%   30.63%   -0.01%     
==========================================
  Files         216      216              
  Lines       17491    17495       +4     
  Branches     2386     2388       +2     
==========================================
+ Hits         5359     5360       +1     
- Misses      11917    11919       +2     
- Partials      215      216       +1
Impacted Files Coverage Δ
app/marketing/models.py 61.27% <100%> (ø) ⬆️
app/marketing/utils.py 32.45% <40%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d417243...e1b3e2d. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #4936 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4936      +/-   ##
==========================================
- Coverage   30.63%   30.63%   -0.01%     
==========================================
  Files         216      216              
  Lines       17491    17495       +4     
  Branches     2386     2388       +2     
==========================================
+ Hits         5359     5360       +1     
- Misses      11917    11918       +1     
- Partials      215      217       +2
Impacted Files Coverage Δ
app/marketing/models.py 61.27% <100%> (ø) ⬆️
app/marketing/utils.py 32.45% <40%> (-0.21%) ⬇️
app/dashboard/views.py 14.19% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1058a00...e4c4239. Read the comment docs.

@thelostone-mc thelostone-mc merged commit f0cb839 into master Aug 2, 2019
@thelostone-mc thelostone-mc deleted the suppression-regex branch August 2, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants