Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit info on grant page #4928

Merged
merged 20 commits into from
Aug 2, 2019

Conversation

PierrickGT
Copy link
Contributor

Description

As a grant owner, I wish to be able to edit infos of my grant.
This PR fix a bug who made it impossible to edit infos of a grant if you where not doing it from the first tab, it was due to the Quill editor not being conditioned to be loaded only on the first tab.

Screencast

Here is a recording of the fix
fix screencast

Refers/Fixes

Bounty: https://gitcoin.co/issue/gitcoinco/web/4786/3227
Issue: #4786

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #4928 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
- Coverage   30.63%   30.63%   -0.01%     
==========================================
  Files         216      216              
  Lines       17495    17496       +1     
  Branches     2388     2389       +1     
==========================================
  Hits         5360     5360              
- Misses      11919    11920       +1     
  Partials      216      216
Impacted Files Coverage Δ
app/grants/views.py 13.85% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cb839...04433c8. Read the comment docs.

@thelostone-mc
Copy link
Member

@danlipert / @octavioamu Tested it out locally to ensure it's working
Untitled

@thelostone-mc thelostone-mc merged commit 43331e2 into gitcoinco:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants