-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edit info on grant page #4928
Merged
thelostone-mc
merged 20 commits into
gitcoinco:master
from
PierrickGT:fixes/grant-edit_info
Aug 2, 2019
Merged
Fix edit info on grant page #4928
thelostone-mc
merged 20 commits into
gitcoinco:master
from
PierrickGT:fixes/grant-edit_info
Aug 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
July 31, 2019 18:55
Codecov Report
@@ Coverage Diff @@
## master #4928 +/- ##
==========================================
- Coverage 30.63% 30.63% -0.01%
==========================================
Files 216 216
Lines 17495 17496 +1
Branches 2388 2389 +1
==========================================
Hits 5360 5360
- Misses 11919 11920 +1
Partials 216 216
Continue to review full report at Codecov.
|
@danlipert / @octavioamu Tested it out locally to ensure it's working |
thelostone-mc
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a grant owner, I wish to be able to edit infos of my grant.
This PR fix a bug who made it impossible to edit infos of a grant if you where not doing it from the first tab, it was due to the Quill editor not being conditioned to be loaded only on the first tab.
Screencast
Here is a recording of the fix
Refers/Fixes
Bounty: https://gitcoin.co/issue/gitcoinco/web/4786/3227
Issue: #4786