Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate function #4923

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 31, 2019

Description

@danlipert
Copy link
Contributor

@owocki the change on stable to the rounding function caused advanced payout to fail - this PR fixes it

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #4923 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4923   +/-   ##
=======================================
  Coverage   30.63%   30.63%           
=======================================
  Files         216      216           
  Lines       17491    17491           
  Branches     2386     2386           
=======================================
  Hits         5359     5359           
- Misses      11916    11917    +1     
+ Partials      216      215    -1
Impacted Files Coverage Δ
app/dashboard/views.py 14.19% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdc50e...6997f5c. Read the comment docs.

@thelostone-mc thelostone-mc merged commit d417243 into gitcoinco:master Jul 31, 2019
@owocki
Copy link
Contributor

owocki commented Jul 31, 2019

thanks good catch

@thelostone-mc thelostone-mc deleted the _mig branch January 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants