Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add card desc for grow eth hackathon #4914

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Conversation

danlipert
Copy link
Contributor

Description

Adds a custom card_desc for grow ethereum hackathon

Refers/Fixes

Longer term fix described here: #4913

Testing

Untested

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #4914 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4914      +/-   ##
=========================================
- Coverage    30.7%   30.7%   -0.01%     
=========================================
  Files         216     216              
  Lines       17429   17431       +2     
  Branches     2364    2365       +1     
=========================================
  Hits         5352    5352              
- Misses      11862   11864       +2     
  Partials      215     215
Impacted Files Coverage Δ
app/dashboard/views.py 14.28% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51654f...9f1d15f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@97e4662). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4914   +/-   ##
========================================
  Coverage          ?   30.7%           
========================================
  Files             ?     216           
  Lines             ?   17431           
  Branches          ?    2365           
========================================
  Hits              ?    5352           
  Misses            ?   11864           
  Partials          ?     215
Impacted Files Coverage Δ
app/dashboard/views.py 14.28% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e4662...e8a6fbf. Read the comment docs.

@@ -2826,6 +2826,9 @@ def hackathon(request, hackathon=''):
'sponsors_silver': sponsors_silver
}

if hackathon_event.identifier == 'grow-ethereum-2019':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol 😂

@thelostone-mc thelostone-mc merged commit 6ce75a1 into master Jul 31, 2019
@thelostone-mc thelostone-mc deleted the grow-eth-card-desc branch June 27, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants