crowdfund contribs + USD estimates for them were completely jacked #4912
Conversation
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
| @@ -1347,6 +1347,10 @@ function normalizeAmount(amount, decimals) { | |||
| return Math.round((parseInt(amount) / Math.pow(10, decimals)) * 1000) / 1000; | |||
| } | |||
|
|
|||
| function round(amount, decimals) { | |||
There was a problem hiding this comment.
@gitcoinco/engineers
heres what the programmer who built the crowdfund contributions functionality didnt know (and i guess didnt test):
normalizeAmount() != round()
normalizeAmount() was originally meant to take a token (which is stored as an int which represents a float value * 10**decimals) and transfer from amount from that int into that float value.
i guess this was a case of bad documentation and bad method naming.
There was a problem hiding this comment.
Makes sense - theres a lot we can communicate in terms of code readability just by picking descriptive method and variable names @thelostone-mc @octavioamu something to keep in mind :)
Codecov Report
@@ Coverage Diff @@
## stable #4912 +/- ##
=======================================
Coverage 30.62% 30.62%
=======================================
Files 216 216
Lines 17402 17402
Branches 2364 2364
=======================================
Hits 5329 5329
Misses 11858 11858
Partials 215 215Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable #4912 +/- ##
=======================================
Coverage 30.62% 30.62%
=======================================
Files 216 216
Lines 17402 17402
Branches 2364 2364
=======================================
Hits 5329 5329
Misses 11858 11858
Partials 215 215Continue to review full report at Codecov.
|
Description
https://gitcoin.co/issue/ethereum/EIPs/2221/3296
this bounty (a) shows $4.91 USD as the USD amount when there is 1.189 ETH on the main bounty and 1.12 ETH on the crowdfund. (b) not show the 1.12 ETH in crowdfund.
fix before / after:
Refers/Fixes
https://gitcoincore.slack.com/archives/CAXQ7PT60/p1564565072006400
Testing
tested locally