-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to sync Github issue #4899
Add button to sync Github issue #4899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4899 +/- ##
==========================================
- Coverage 30.82% 30.82% -0.01%
==========================================
Files 216 216
Lines 17387 17388 +1
Branches 2374 2375 +1
==========================================
Hits 5359 5359
- Misses 11811 11812 +1
Partials 217 217
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Looks great - lots of people will be stoked for this!
Thank you! I will submit my work tonight once I get home. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
I'm gonna need @thelostone-mc to approve me as a worker cause I can't submit my work for now. |
} | ||
).fail( | ||
function(result) { | ||
var alertMsg = result && result.responseJSON ? result.responseJSON.error : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we update this to let
?
function(result) { | ||
var alertMsg = result && result.responseJSON ? result.responseJSON.error : null; | ||
|
||
if (alertMsg === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on making it as
let alertMsg = result && result.responseJSON ? result.responseJSON.error : gettext('Failed to sync issue. Please reload the page and try again.');
} | ||
); | ||
}).fail(function(result) { | ||
var alertMsg = result && result.responseJSON ? result.responseJSON.error : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ let
}).fail(function(result) { | ||
var alertMsg = result && result.responseJSON ? result.responseJSON.error : null; | ||
|
||
if (alertMsg === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let alertMsg = result && result.responseJSON ? result.responseJSON.error : gettext('Failed to sync issue. Please reload the page and try again.');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments !
Otherwise damn neat 🙌
Ah I'm not sure what happened. I did approve it after we synced up on how you'd tackle this.
Nevertheless -> approved now
@thelostone-mc I've updated the |
Description
As a bounty owner, I wish to be able to update my bounty description by syncing from Github.
This PR adds a Sync Issue button that allows a bounty owner to easily update the bounty description.
Refers/Fixes
Issue: #4870