Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open hackathon bounties to normal explorer #4894

Merged
merged 6 commits into from
Aug 7, 2019
Merged

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jul 30, 2019

Description

change query to show hackathon bounties into normal explorer

Refers/Fixes

Ref #4853

Testing

image
image

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #4894 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4894      +/-   ##
==========================================
+ Coverage   30.84%   30.84%   +<.01%     
==========================================
  Files         217      217              
  Lines       17398    17397       -1     
  Branches     2376     2376              
==========================================
  Hits         5366     5366              
+ Misses      11815    11813       -2     
- Partials      217      218       +1
Impacted Files Coverage Δ
app/dashboard/router.py 34.82% <ø> (+0.15%) ⬆️
app/dashboard/views.py 14.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddfa05...9f32a2f. Read the comment docs.

@danlipert
Copy link
Contributor

Seems legit to me - did you try booting it up in docker just to double check?

@octavioamu
Copy link
Contributor Author

octavioamu commented Jul 30, 2019

Seems legit to me - did you try booting it up in docker just to double check?

ohh I didn't restart docker, Just made the change and checked the explorer. Let me send a print for tests

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might come back to bite us
If you click on the hackathon bounty and then click on back to explorer link -> you'll end up on the hackathon explorer which would confuse users a bit.
a
Might be worth updating UI to add both Hackathon + Explorer link for hackathon bounties ?
@octavioamu

@danlipert
Copy link
Contributor

This might come back to bite us
If you click on the hackathon bounty and then click on back to explorer link -> you'll end up on the hackathon explorer which would confuse users a bit.
a
Might be worth updating UI to add both Hackathon + Explorer link for hackathon bounties ?
@octavioamu

I agree this would be nice to fix but I don't think its a blocker - we can add that later if we decide we want to

@danlipert danlipert merged commit 7918d3b into master Aug 7, 2019
@thelostone-mc thelostone-mc deleted the open-hackathon-bounties branch June 27, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants