-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open hackathon bounties to normal explorer #4894
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4894 +/- ##
==========================================
+ Coverage 30.84% 30.84% +<.01%
==========================================
Files 217 217
Lines 17398 17397 -1
Branches 2376 2376
==========================================
Hits 5366 5366
+ Misses 11815 11813 -2
- Partials 217 218 +1
Continue to review full report at Codecov.
|
Seems legit to me - did you try booting it up in docker just to double check? |
ohh I didn't restart docker, Just made the change and checked the explorer. Let me send a print for tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might come back to bite us
If you click on the hackathon bounty and then click on back to explorer link -> you'll end up on the hackathon explorer which would confuse users a bit.
a
Might be worth updating UI to add both Hackathon + Explorer link for hackathon bounties ?
@octavioamu
I agree this would be nice to fix but I don't think its a blocker - we can add that later if we decide we want to |
Description
change query to show hackathon bounties into normal explorer
Refers/Fixes
Ref #4853
Testing