-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purge: remove grant ownership feature #4878
Conversation
Looks good @thelostone-mc - we should also remove the little down arrow in the grant owner box since that makes it look like you can change it. Also the audio was on in your video :P |
Derp derp ! I forgot to turn out the audio :P This is what it looks like now if you are logged in as the grant owner ^_^ |
Codecov Report
@@ Coverage Diff @@
## master #4878 +/- ##
=========================================
Coverage ? 30.82%
=========================================
Files ? 216
Lines ? 17387
Branches ? 2374
=========================================
Hits ? 5359
Misses ? 11811
Partials ? 217
Continue to review full report at Codecov.
|
aeb2892
to
5a5d196
Compare
rebased + retested |
this caused a regression here @thelostone-mc #5026 |
Description
removes grant ownership feature in grant.
Once a grant has been created, the grant owner can
Refers/Fixes
closes #4839
Testing
Demo : https://embed.vidyard.com/share/pkJZKTs3GjcQZcP42aJHf9?