Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge: remove grant ownership feature #4878

Merged
merged 5 commits into from
Aug 7, 2019

Conversation

thelostone-mc
Copy link
Member

Description

removes grant ownership feature in grant.
Once a grant has been created, the grant owner can

  • edit grant info
  • cancel grant (if logged in with the address with which the grant is created )
Refers/Fixes

closes #4839

Testing
  • Created Grant
  • Edited Grant Info
  • Cancel Grant
  • Edit Grant via Admin

Demo : https://embed.vidyard.com/share/pkJZKTs3GjcQZcP42aJHf9?

@danlipert
Copy link
Contributor

Looks good @thelostone-mc - we should also remove the little down arrow in the grant owner box since that makes it look like you can change it. Also the audio was on in your video :P

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Jul 31, 2019

Derp derp ! I forgot to turn out the audio :P
@danlipert removed the title dropdown

This is what it looks like now if you are logged in as the grant owner ^_^

screencapture-localhost-8000-grants-2-new-da-grant-2019-07-31-13_06_02

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ec99266). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4878   +/-   ##
=========================================
  Coverage          ?   30.82%           
=========================================
  Files             ?      216           
  Lines             ?    17387           
  Branches          ?     2374           
=========================================
  Hits              ?     5359           
  Misses            ?    11811           
  Partials          ?      217
Impacted Files Coverage Δ
app/marketing/mails.py 14.36% <ø> (ø)
app/grants/models.py 59.39% <ø> (ø)
app/grants/admin.py 42.68% <ø> (ø)
app/retail/emails.py 23.59% <ø> (ø)
app/app/urls.py 89.36% <ø> (ø)
app/grants/views.py 14.78% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec99266...686febc. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the purge branch 2 times, most recently from aeb2892 to 5a5d196 Compare July 31, 2019 09:18
@thelostone-mc
Copy link
Member Author

rebased + retested
@octavioamu / @danlipert

@thelostone-mc thelostone-mc merged commit 456e64a into gitcoinco:master Aug 7, 2019
@owocki
Copy link
Contributor

owocki commented Aug 16, 2019

this caused a regression here @thelostone-mc #5026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Grants Gitcoin Grants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

purge: grant change ownership feature
4 participants