-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job status tab bugs #4877
Job status tab bugs #4877
Conversation
and only return an error if there is no resume file AND there is not already a resume for the profile in Fixes: Bug 2 of gitcoinco#4867
Codecov Report
@@ Coverage Diff @@
## master #4877 +/- ##
==========================================
- Coverage 30.64% 30.63% -0.01%
==========================================
Files 216 216
Lines 17411 17419 +8
Branches 2364 2366 +2
==========================================
+ Hits 5336 5337 +1
- Misses 11860 11867 +7
Partials 215 215
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4877 +/- ##
==========================================
+ Coverage 30.64% 30.69% +0.05%
==========================================
Files 216 216
Lines 17411 17438 +27
Branches 2364 2367 +3
==========================================
+ Hits 5336 5353 +17
- Misses 11860 11870 +10
Partials 215 215
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise LGTM !
Could you add a working demo of the PR ? ^_^
Also kudos for the neat commit message
@thelostone-mc Thanks! This is my first PR, what would a working demo look like? |
Great @Adamits thanks for this. What @thelostone-mc is asking is for a video showing how is working with this changes, you can use this tool or any other. |
Great - will do when i'm home from work tonight. |
Thanks @Adamits |
Hi, Upon fixing my mistake, I noticed that there is a comment showing the intended way for this to function originally was to simply catch the status code 400 or the no file upload error, and the bug is simply that they catch for a string, rather than int in the condition. Closing this PR and ill submit a new one with that simple fix... The original issue has also been updated with steps to reproduce BUG 1, so I will address that as well in the new PR. |
Description
This fixes a minor bug in the
settings/job
page wherein a user needs to re-upload a new resume every time they want to save an update.Refers/Fixes
Fix Bug 2 of #4867
Testing
Tested locally in browser