fix failing tests in master #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4875 +/- ##
==========================================
+ Coverage 30.63% 30.64% +0.01%
==========================================
Files 216 216
Lines 17407 17407
Branches 2363 2363
==========================================
+ Hits 5332 5335 +3
+ Misses 11860 11857 -3
Partials 215 215
Continue to review full report at Codecov.
|
octavioamu
approved these changes
Jul 26, 2019
owocki
reviewed
Jul 26, 2019
| @@ -216,5 +216,5 @@ def github_avatar(cls, profile, avatar_img): | |||
| @receiver(post_save, sender=CustomAvatar, dispatch_uid="psave_avatar2") | |||
| def psave_avatar(sender, instance, **kwargs): | |||
| from dashboard.models import Activity | |||
| metadata = {'url': instance.png.url, } | |||
There was a problem hiding this comment.
sorry, my bad. i should have run make tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing tests in master
Refers/Fixes
no issue
Testing
tested locally