Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sitemap kudos url #4855

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Fix sitemap kudos url #4855

merged 2 commits into from
Jul 24, 2019

Conversation

octavioamu
Copy link
Contributor

Description

Fixed sitemap kudos url to be relative, since actually the urls are wrong.

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8e47405). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4855   +/-   ##
=========================================
  Coverage          ?   30.44%           
=========================================
  Files             ?      216           
  Lines             ?    17335           
  Branches          ?     2353           
=========================================
  Hits              ?     5277           
  Misses            ?    11849           
  Partials          ?      209
Impacted Files Coverage Δ
app/app/sitemaps.py 62.12% <0%> (ø)
app/kudos/models.py 54.7% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e47405...f5bb0cc. Read the comment docs.

@danlipert danlipert merged commit 3d699c7 into master Jul 24, 2019
@thelostone-mc thelostone-mc deleted the fix/kudos-sitemap branch June 27, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants